-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement useDateField
with @internationalized/date
#132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 379b5cf The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
9975e05
to
a586c96
Compare
24a3b2d
to
77f427f
Compare
commit: |
77f427f
to
987be85
Compare
1389a79
to
1f1d7b7
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Swaps out the temporal implementation in #115 for @internationalized/date.
Why
While I loved working with temporals, the fact that they are not widely supported yet is not encouraging. I would have proceeded with them if they were at least Baseline supported.
My main reasons are:
@js-temporal/polyfill
is56.7kb
gzipped.temporal-polyfill
is20.5kb
gzipped.@internationalized/date
is10.9kb
gzipped.@internationalized/date
is a little more common in the ecosystem and has utility outside formwerk use.I think once temporals hit baseline, we will make that switch, its such a shame because it is a great API imo. Another alternative, is we find or fork or build a minimal version of the temporal spec and use it internally.