fix: optimizations for jobs/parse-logs.js

forwardemail · Feb 27, 2025 · a0d4f55 · a0d4f55
1 parent e7e9d51
commit a0d4f55
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 14 deletions.
diff --git a/app/models/logs.js b/app/models/logs.js
@@ -287,6 +287,14 @@ const PARTIAL_INDICES = [
   // meta.session.headers
 ];
 
+// indices for jobs/parse-logs.js
+Logs.index({
+  is_restricted: 1,
+  domains: 1,
+  domains_checked_at: 1
+});
+
+// indices for my account > logs
 Logs.index({ bounce_category: 1, domains: 1 }); // admin
 Logs.index({ bounce_category: 1, domains: 1, user: 1 }); // non-admin
 Logs.index({ bounce_category: 1, domains: 1, 'meta.app.hostname': 1 });

diff --git a/jobs/parse-logs.js b/jobs/parse-logs.js
@@ -118,20 +118,15 @@ graceful.listen();
         log.skip_duplicate_check = true;
         await log.save();
       } catch (err) {
-        if (err.is_denylist_without_domains) {
-          try {
-            await Logs.deleteOne(
-              { _id: log._id },
-              {
-                writeConcern: { w: 0, j: false }
-              }
-            );
-          } catch (err) {
-            logger.error(err);
-          }
-        } else {
-          logger.error(err);
-        }
+        if (err.is_denylist_without_domains)
+          Logs.deleteOne(
+            { _id: log._id },
+            {
+              writeConcern: { w: 0, j: false }
+            }
+          )
+            .then()
+            .catch((err) => logger.error(err));
       }
     }
   } catch (err) {