Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implemented ReCaptcha Verification in sign_up process #2446

Closed
wants to merge 2 commits into from
Closed

feat: Implemented ReCaptcha Verification in sign_up process #2446

wants to merge 2 commits into from

Conversation

s-ayush2903
Copy link

@s-ayush2903 s-ayush2903 commented Jan 9, 2020

Fixes #2350

Changes: Some dependencies required for ReCaptcha implementation were added, and corresponding changes were made accordingly.

I am with this embedding two screenRecordings that display the proposed changes.

(This represents the state of the app when the key is present)
GIF-200109_151419

(And This represents the state of the app when the key is not present)
GIF-200109_152147

@auto-label auto-label bot added the feature label Jan 9, 2020
@atm1504
Copy link
Member

atm1504 commented Jan 9, 2020

Why did you create a pr for an issue that has already been claimed by someone else, who has already made a pr?

@s-ayush2903 s-ayush2903 closed this Jan 9, 2020
@s-ayush2903
Copy link
Author

Why did you create a pr for an issue that has already been claimed by someone else, who has already made a pr?

My apologies, Sorry!

@s-ayush2903
Copy link
Author

s-ayush2903 commented Jan 9, 2020

As the above pull request makes the changes that were asked to make in the #2360 and to satisfy which, another #2444 was opened and neither of which includes the requested changes like ReCaptcha_Key storage issue and the build issue(e.g. the build fails in both of the previous MRs when key is not supplied) and the issue related to usage of timber, so REOPENING it.

@s-ayush2903 s-ayush2903 reopened this Jan 9, 2020
@s-ayush2903
Copy link
Author

@liveHarshit please review

@ci-reporter
Copy link

ci-reporter bot commented Jan 11, 2020

The build is failing

✨ Good work on this PR so far! ✨ Unfortunately, the Circle CI build is failing as of db2b51f. Here's the output:

spotless check
> Task :spotlessCheck UP-TO-DATE

I'm sure you can fix it! If you need help, don't hesitate to ask a maintainer of the project!


Failed build for db2b51f
spotless check
> Task :spotlessCheck UP-TO-DATE

This comment was automagically generated by ci-reporter. If you see a problem, open an issue here.

@batbrain7
Copy link
Member

@s-ayush2903 status ?

@angmas1
Copy link

angmas1 commented Feb 14, 2020

@s-ayush2903 are you still working on this?

@s-ayush2903 s-ayush2903 closed this Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ReCaptcha for Signup attempt
4 participants