Change the vac vraag field location #1054
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Moved the `antwoord` field to a higher level in the vac collection. - Kept the old field temporarily for data migration. - This change allows Strapi to use vraag as the entry label in the dashboard.
…erige-objecten-api
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This was
linked to
issues
Feb 26, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
Robbert
reviewed
Feb 28, 2025
| - [#1046](https://github.com/frameless/strapi/issues/1046). | ||
| - [#1040](https://github.com/frameless/strapi/issues/1040). | ||
|
|
||
| **Wijzegingen**: |
There was a problem hiding this comment.
Suggested change
| **Wijzegingen**: | |
| **Wijzigingen**: |
|
|
||
| Update VAC-collectiestructuur | ||
|
|
||
| **GitHub Issue frameless**: |
There was a problem hiding this comment.
Suggested change
| **GitHub Issue frameless**: | |
| **GitHub Issue Frameless**: |
| geometry: null, | ||
| endAt: null, | ||
| registrationAt: createdAt, | ||
| const VacResponse = getVacData({ |
There was a problem hiding this comment.
Het is geen interface, dus ik stel voor dat je dit als vacResponse schrijft
| @@ -70,7 +70,7 @@ export const objectsResponseData = ({ type }: { type?: 'kennisartikel' | 'vac' } | |||
| status: 'actief', | |||
| antwoord: | |||
| 'U moet een afspraak maken bij de gemeente, uw identiteitsbewijs meenemen en een recente pasfoto aanleveren.', | |||
| doelgroep: 'eu_burger', | |||
| doelgroep: 'eu-burger', | |||
There was a problem hiding this comment.
Hoe komt de aanpassing van _ naar -? Is dit een breaking change voor acc/prod?
| vacSchemaURL: string; | ||
| serverURL: string; | ||
| } | ||
| interface MapVAcItemProps extends Pick<GetVacDataProps, 'serverURL' | 'vacSchemaURL'> { |
There was a problem hiding this comment.
Suggested change
| interface MapVAcItemProps extends Pick<GetVacDataProps, 'serverURL' | 'vacSchemaURL'> { | |
| interface MapVacItemProps extends Pick<GetVacDataProps, 'serverURL' | 'vacSchemaURL'> { |
en natuurlijk ook op de andere plekken aanpassen
| @@ -22,7 +22,7 @@ | |||
| "vraag": { | |||
| "edit": { | |||
| "label": "Vraag", | |||
| "description": "", | |||
| "description": "🔔 Let op: Dit veld is verouderd en zal binnenkort worden verwijderd. Gebruik in plaats daarvan het nieuwe veld bovenaan.", | |||
There was a problem hiding this comment.
Suggested change
| "description": "🔔 Let op: Dit veld is verouderd en zal binnenkort worden verwijderd. Gebruik in plaats daarvan het nieuwe veld bovenaan.", | |
| "description": "🔔 Let op: Dit veld is verouderd en zal binnenkort worden verwijderd. Verplaats de informatie naar het veld \"Vraag\" bovenaan.", |
|
|
||
| const getAntwoord = (antwoord: Antwoord[]): string => (Array.isArray(antwoord) ? concatenateFieldValues(antwoord) : ''); | ||
|
|
||
| const createVacRecord = (item: DataVacItem, vacUrl: string, antwoord: string) => { |
There was a problem hiding this comment.
Hoe weten we of de return value compleet is? Is hier geen typescript interface voor?
|
|
||
| const getAntwoord = (antwoord: Antwoord[]): string => (Array.isArray(antwoord) ? concatenateFieldValues(antwoord) : ''); | ||
|
|
||
| const createVacRecord = (item: DataVacItem, vacUrl: string, antwoord: string) => { |
There was a problem hiding this comment.
Hier verwacht ik een return type
| @@ -0,0 +1,52 @@ | |||
| import kebabCase from 'lodash.kebabcase'; | |||
There was a problem hiding this comment.
Klopt het dat de filename getVacData copy.ts is? Met een spatie?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issues: