Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(General Ledger Report): Grouped Print #17662

Closed

Conversation

SaiFi0102
Copy link
Collaborator

@SaiFi0102 SaiFi0102 commented May 17, 2019

Requires frappe/frappe#7455 and frappe/datatable#66 for grouping feature
Includes PR #16658

Report View
General ledger report view

Print View
General ledger report view

SaiFi0102 and others added 30 commits November 19, 2018 00:33
-Added reference_no and reference_date in GL Entry
-Added cheque_no, cheque_date, clearance_date in Journal Entry Account child table
-Removed clearance_date from Journal Entry
-Using cheque_no and cheque_date in Journal Entry as UI fields
-Added reference_numbers field for List View of Journal Entry which concatenates all the cheque_no's in the child table
-Journal Entry will only post remarks from user_remark from Journal Entry Account and Journal Entry to GL Entry
-Added reference_no and reference_date columns
-Rearranged columns according to their importance
-Added filter for reference_no and against_voucher
-Rearranged filters to group them better
-Create remarks in validation
-Added extra fields in Bank Reconciliation Tool to show Journal Entry name but keep information about Journal Entry Accounts table row name
-Added a patch to migrate Journal Entry cheque_no, cheque_date and clearance_date to Journal Entry Account
-Removed set_reqd for cheque_no and cheque_date Journal Entry with type Bank Entry
-Added user remark in Payment Entry
-Made remarks fields Global Searchable
-Minor fixes
-Changed Reference Type/Name to Against Document Type/Name
-Aggregate reference_nos, reference_date and against_voucher
-Allow detailed ungrouped by selecting Group By field as empty again

General Ledger Print Format:
-Split against accounts by ', ' and ',' both
…ultiple-Reference-No

# Conflicts:
#	erpnext/accounts/report/accounts_receivable/accounts_receivable.py
#	erpnext/patches.txt
…om/SaiFi0102/erpnext.git into JV-Multiple-Reference-No-V12
…om/SaiFi0102/erpnext.git into JV-Multiple-Reference-No-V12
…om/SaiFi0102/erpnext.git into JV-Multiple-Reference-No-V12
…om/SaiFi0102/erpnext.git into JV-Multiple-Reference-No-V12
…JV-Multiple-Reference-No-V12

# Conflicts:
#	erpnext/accounts/doctype/bank_reconciliation/bank_reconciliation.py
#	erpnext/accounts/doctype/journal_entry_account/journal_entry_account.json
#	erpnext/accounts/doctype/payment_entry/payment_entry.json
#	erpnext/accounts/doctype/purchase_invoice/purchase_invoice.json
#	erpnext/accounts/doctype/sales_invoice/sales_invoice.json
#	erpnext/buying/doctype/purchase_order/purchase_order.json
#	erpnext/patches.txt
#	erpnext/selling/doctype/sales_order/sales_order.json
#	erpnext/stock/doctype/delivery_note/delivery_note.json
#	erpnext/stock/doctype/purchase_receipt/purchase_receipt.json
#	erpnext/stock/doctype/stock_entry/stock_entry.json
…hub.com/SaiFi0102/erpnext.git into General-Ledger-Grouped-Report-V12

# Conflicts:
#	erpnext/public/js/controllers/stock_controller.js
@SaiFi0102 SaiFi0102 changed the title feat: Grouped General Ledger Enhancement feat(General Ledger Report): Grouped Print May 19, 2019
@stale
Copy link

stale bot commented Jun 24, 2019

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed within a week if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

@stale stale bot added the inactive label Jun 24, 2019
@stale stale bot closed this Jul 1, 2019
@stale stale bot removed the inactive label Jul 12, 2019
@stale
Copy link

stale bot commented Aug 11, 2019

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed within a week if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

@stale stale bot added the inactive label Aug 11, 2019
@stale stale bot closed this Aug 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants