Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recognize uname -m returning arm64 (as it currently does on m1 mac) #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

scgilardi
Copy link

@scgilardi scgilardi commented Sep 30, 2022

With this change, babashka installs successfully on my m1 mac. Before the change it complains about unbound var "arch". I think this supersedes Pull request #4 and resolves issue #3 .

  • the current version of apple command line tools (see below) on m1 mac returns "arm64" from uname -m

  • update so we recognize that and download the apple silicon build from babashka releases

  • also, on a failure to recognize uname -m output, make it clear which package (asdf-babashka) is having the problem.

  • ➜ lib git:(master) ✗ pkgutil -pkg-info=com.apple.pkg.CLTools_Executables
    package-id: com.apple.pkg.CLTools_Executables version: 14.0.0.0.1.1661618636 [...]

- the current version of apple command line tools (see below) on m1 mac
  returns "arm64" from `uname -m`
- update so we recognize that and download the apple silicon build from
  babashka releases
- also, on a failure to recognize `uname -m` output, make it clear which
  package (asdf-babashka) is having the problem.

- ➜  lib git:(master) ✗ pkgutil -pkg-info=com.apple.pkg.CLTools_Executables
  package-id: com.apple.pkg.CLTools_Executables
  version: 14.0.0.0.1.1661618636
  [...]
@scgilardi
Copy link
Author

I'm now thinking my mention of the command line tools and their version is irrelevant. uname is almost certainly part of the OS proper. That version is 12.6 .

@fredZen
Copy link
Owner

fredZen commented Sep 30, 2022 via email

@pvinis
Copy link

pvinis commented Dec 1, 2022

👀

@borkdude
Copy link

borkdude commented Jan 6, 2023

@fredZen Any chance you could merge this? Babashka on m1 currently doesn't work properly with this asdf plugin.

@pesterhazy
Copy link

Like @borkdude I'd love to see this land in master. Happy to help out with maintenance duties if time is of short supply

@borkdude
Copy link

This PR was merged over here in this fork:

asdf plugin add babashka https://github.com/mkarp/asdf-babashka.git

@pesterhazy
Copy link

Use this fork over @mkarp's. We're using babashka heavily at Pitch and are happy to help out with maintaining the fork while upstream is not responsive https://github.com/pitch-io/asdf-babashka

@acidghost
Copy link

@fredZen @borkdude @pesterhazy @mkarp @pitch-io
I'm trying to have this plugin replaced by the pitch.io fork (see asdf-vm/asdf-plugins#784).

Unfortunately the fork has two problems: does not accept issues and does not implement CI.

The first is needed for transparency and good OSS (I would not have to write here and ping people if I could open an issue there).

The latter is required to instill a bit of trust of recommended asdf plugins actually working.

@pesterhazy
Copy link

pesterhazy commented Mar 30, 2023 via email

@acidghost
Copy link

@pesterhazy Gentle reminder :)

@pesterhazy
Copy link

@acidghost thanks for the ping

Issues enabled, working on Github Actions now pitch-io#1

@pesterhazy
Copy link

@acidghost I've enabled Github Actions as well now

Let me know if there's anything else we should do to get this fork ready for asdf-plugins

@acidghost
Copy link

@pesterhazy Apparently not, the changes have been merged (https://github.com/asdf-vm/asdf-plugins#plugin-list).

@pesterhazy
Copy link

Excellent, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants