-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
recognize uname -m
returning arm64 (as it currently does on m1 mac)
#5
base: master
Are you sure you want to change the base?
Conversation
- the current version of apple command line tools (see below) on m1 mac returns "arm64" from `uname -m` - update so we recognize that and download the apple silicon build from babashka releases - also, on a failure to recognize `uname -m` output, make it clear which package (asdf-babashka) is having the problem. - ➜ lib git:(master) ✗ pkgutil -pkg-info=com.apple.pkg.CLTools_Executables package-id: com.apple.pkg.CLTools_Executables version: 14.0.0.0.1.1661618636 [...]
I'm now thinking my mention of the command line tools and their version is irrelevant. uname is almost certainly part of the OS proper. That version is 12.6 . |
Hi Stephen, thank you for your contribution. Sorry for letting #4 / #3 linger for so long (personal life got in the way), I'll try and integrate your fix but it might take until monday depending on how things go
Ven 30 sept 2022, à 16:37, Stephen C. Gilardi a écrit :
…
I'm now thinking my mention of the command line tools and their version is irrelevant. uname is almost certainly part of the OS proper. That version is 12.6 .
—
Reply to this email directly, view it on GitHub <#5 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACXBWQ7GCBGDJQSECDAVSLWA33KLANCNFSM6AAAAAAQZZEVHU>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
👀 |
@fredZen Any chance you could merge this? Babashka on m1 currently doesn't work properly with this asdf plugin. |
Like @borkdude I'd love to see this land in master. Happy to help out with maintenance duties if time is of short supply |
This PR was merged over here in this fork:
|
Use this fork over @mkarp's. We're using babashka heavily at Pitch and are happy to help out with maintaining the fork while upstream is not responsive https://github.com/pitch-io/asdf-babashka |
@fredZen @borkdude @pesterhazy @mkarp @pitch-io Unfortunately the fork has two problems: does not accept issues and does not implement CI. The first is needed for transparency and good OSS (I would not have to write here and ping people if I could open an issue there). The latter is required to instill a bit of trust of recommended asdf plugins actually working. |
Hi Andrea, fair points. I will look into it when I'm back in the office in
mid April.
…On Thu 23. Mar 2023 at 08:13, Andrea Jemmett ***@***.***> wrote:
@fredZen <https://github.com/fredZen> @borkdude
<https://github.com/borkdude> @pesterhazy <https://github.com/pesterhazy>
@mkarp <https://github.com/mkarp> @pitch-io <https://github.com/pitch-io>
I'm trying to have this plugin replaced by the pitch.io fork (see
asdf-vm/asdf-plugins#784
<asdf-vm/asdf-plugins#784>).
Unfortunately the fork has two problems: does not accept issues and does
not implement CI.
The first is needed for transparency and good OSS (I would not have to
write here and ping people if I could open an issue there).
The latter is required to instill a bit of trust of recommended asdf
plugins actually working.
—
Reply to this email directly, view it on GitHub
<#5 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAZ6WEFW4UEFMGYZVBJ3XTW5PZY7ANCNFSM6AAAAAAQZZEVHU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@pesterhazy Gentle reminder :) |
@acidghost thanks for the ping Issues enabled, working on Github Actions now pitch-io#1 |
@acidghost I've enabled Github Actions as well now Let me know if there's anything else we should do to get this fork ready for asdf-plugins |
@pesterhazy Apparently not, the changes have been merged (https://github.com/asdf-vm/asdf-plugins#plugin-list). |
Excellent, thanks! |
With this change, babashka installs successfully on my m1 mac. Before the change it complains about unbound var "arch". I think this supersedes Pull request #4 and resolves issue #3 .
the current version of apple command line tools (see below) on m1 mac returns "arm64" from
uname -m
update so we recognize that and download the apple silicon build from babashka releases
also, on a failure to recognize
uname -m
output, make it clear which package (asdf-babashka) is having the problem.➜ lib git:(master) ✗ pkgutil -pkg-info=com.apple.pkg.CLTools_Executables
package-id: com.apple.pkg.CLTools_Executables version: 14.0.0.0.1.1661618636 [...]