-
-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: move playwright tests from main repo #1341
base: main
Are you sure you want to change the base?
chore: move playwright tests from main repo #1341
Conversation
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
@Sembauke are the Flutter tests expected to fail or did I break something? |
paths: | ||
- "mobile-app/**" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you undo this change? We don't want the e2e tests to run for any changes within the mobile API code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay, Niraj, but I've removed that commit.
Yes, the app CI are expected to fail as forked PRs don't have access to secrets when running the action |
94c7b8c
to
c3265e1
Compare
Checklist:
Update index.md
)The rationale is that these tests are of the mobile app, not the learn client. As such it makes more sense for them to be in this repo.
It's a little ugly, though, since we still need to import curriculum data from the main repo.
I converted the spec and test back to js since it did not seem worth configuring TS for two files. At least not right now.