Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make check: Eliminate "operation not permitted" errors #1555

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

make check: Eliminate "operation not permitted" errors #1555

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions share/mk/suite.test.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,8 +118,7 @@ beforecheck:
# times. "aftercheck" won't be run if "make check" fails, is interrupted,
# etc.
Copy link
Contributor Author

@patmaddox patmaddox Dec 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Original code:

# NOTE: this is intentional to ensure that "make check" can be run multiple
#       times. "aftercheck" won't be run if "make check" fails, is interrupted,
#       etc.
aftercheck:
	@cd ${.CURDIR} && ${MAKE} clean
	@test ! -e ${DESTDIR} || chflags -R 0 "${DESTDIR}"
	@rm -Rf "${DESTDIR}"

It's not clear to me if the "this is intentional" comment means that it's intended to set flags after clean, and letting these errors through. That seems strange to me. edit: I think it means that it's intended to put this logic in aftercheck rather than in check, for the "fails, is interrupted, etc" reason.

I addressed this because when running the tests, it was unclear to me if something was wrong with my setup. Error messages shouldn't come up as a part of a normal test run, unless they're expected.

Also: I don't know if this is the sort of thing I should make a Problem Report first for? So a Bugzilla PR "make check gives noisy operation not permitted errors" so there's a place to track / discuss it, and then a github PR to fix it?

Seemed small enough to me that I could just make a GH PR.

Also, is there any reason this shouldn't be part of make clean itself?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message in 38f8fdd has some backstory. I've added @ngie-eign as a reviewer.

aftercheck:
@cd ${.CURDIR} && ${MAKE} clean
@test ! -e ${DESTDIR} || chflags -R 0 "${DESTDIR}"
@rm -Rf "${DESTDIR}"
@cd ${.CURDIR} && ${MAKE} clean

.endif