Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build with .NET 8.0 #2818

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Build with .NET 8.0 #2818

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
d2c975c
Build with .NET 8.0
Thorium Sep 3, 2024
7d3035c
Some more fsproj replace targetframeworks found
Thorium Sep 3, 2024
811a633
It seems GitHub workflow is building as Release
Thorium Sep 3, 2024
9127450
Github workflow pipeline add .NET 8
Thorium Sep 3, 2024
70e89cc
Trying to test if the recursive build.fsx could be avoided
Thorium Sep 3, 2024
fd12d08
RuntimeIdentifiers for net8
Thorium Sep 4, 2024
45981b5
MSBuild.StructuredLogger update to 2.2.337
Thorium Sep 4, 2024
d6d7c74
Trying to avoid dotnet-tool picking net6.0
Thorium Sep 5, 2024
4559dfb
CoreCache.fs is not finding System.Runtime etc that are part of .NET …
Thorium Sep 5, 2024
1d5a9c3
Updated Expecto
Thorium Sep 10, 2024
1971e72
Expecto update part 2
Thorium Sep 10, 2024
c3ce67f
build-script warning update
Thorium Sep 10, 2024
4249c4a
Merge branch 'master' into net8-build
Thorium Sep 10, 2024
af73fe3
As per comment by Numpsy the .NET Framework assembleis have removed t…
Thorium Sep 19, 2024
f2835dc
sorry, forgot Fantomas
Thorium Sep 19, 2024
27b930a
build-script add framework
Thorium Sep 19, 2024
156fe2d
could we run integration test with .NET8 ? (they still seem to fall t…
Thorium Sep 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions .github/workflows/build_and_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,20 @@ jobs:
uses: actions/setup-dotnet@v4
with:
dotnet-version: '6.0.301'
- name: Setup .NET 8
uses: actions/setup-dotnet@v4
with:
dotnet-version: '8.0.304'
- name: Restore dotnet tools
run: dotnet tool restore
- name: remove current fake runner tool
run: dotnet tool uninstall fake-cli
- name: Build temp-packages to break recursive build.fsx
run: dotnet pack -o release/temp-recursion-break -p:Version=99.0.0-local
- name: Build fake runner
run: dotnet pack --version-suffix 1 src/app/fake-cli/fake-cli.fsproj
run: dotnet pack --version-suffix 1 src/app/fake-cli/fake-cli.fsproj -p:Version=99.0.0-local
- name: add fake runner as a tool
run: dotnet tool install fake-cli --add-source "./src/app/fake-cli/bin/Debug" --version 1.0.0-1
run: dotnet tool install fake-cli --add-source "./src/app/fake-cli/bin/Release" --version 99.0.0-local
- name: Build
run: dotnet fake -v build --parallel 3 -e FAKE_DETAILED_ERRORS=true
- name: publish build artifacts
Expand Down
8 changes: 7 additions & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,14 +20,20 @@ jobs:
uses: actions/setup-dotnet@v4
with:
dotnet-version: '6.0.301'
- name: Setup .NET 8
uses: actions/setup-dotnet@v4
with:
dotnet-version: '8.0.304'
- name: Restore dotnet tools
run: dotnet tool restore
- name: remove current fake runner tool
run: dotnet tool uninstall fake-cli
- name: Build temp-packages to break recursive build.fsx
run: dotnet pack -o release/temp-recursion-break -p:Version=99.0.0-local
- name: Build fake runner
run: dotnet pack -p:PackageVersion=${{ github.event.inputs.releaseVersion }} src/app/fake-cli/fake-cli.fsproj
- name: add fake runner as a tool
run: dotnet tool install fake-cli --add-source "./src/app/fake-cli/bin/Debug" --version ${{ github.event.inputs.releaseVersion }}
run: dotnet tool install fake-cli --add-source "./src/app/fake-cli/bin/Release" --version ${{ github.event.inputs.releaseVersion }}
- name: Build
run: dotnet fake build -t Release_BuildAndTest --parallel 3
- name: publish build artifacts
Expand Down
997 changes: 500 additions & 497 deletions .paket/Paket.Restore.targets
View file
Open in desktop

Large diffs are not rendered by default.

88 changes: 44 additions & 44 deletions Fake.sln
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@

Microsoft Visual Studio Solution File, Format Version 12.00
# Visual Studio Version 16
VisualStudioVersion = 16.0.29009.5
# Visual Studio Version 17
VisualStudioVersion = 17.10.35122.118
MinimumVisualStudioVersion = 15.0.26124.0
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "app", "app", "{7BFFAE76-DEE9-417A-A79B-6A6644C4553A}"
EndProject
Expand Down Expand Up @@ -185,15 +185,15 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "TestTools", "TestTools", "{
EndProject
Project("{6EC3EE1D-3C4E-46DD-8F32-0CC8E7565705}") = "Fake.Core.DependencyManager.Paket", "src\app\Fake.Core.DependencyManager.Paket\Fake.Core.DependencyManager.Paket.fsproj", "{F4D3249D-F4EC-4B86-BEA8-3F2314ED9B65}"
EndProject
Project("{F2A71F9B-5D33-465A-A702-920D77279786}") = "Fake.BuildServer.GitHubActions", "src\app\Fake.BuildServer.GitHubActions\Fake.BuildServer.GitHubActions.fsproj", "{AB09E8EB-A66E-4D60-B47C-4F35F439D020}"
Project("{6EC3EE1D-3C4E-46DD-8F32-0CC8E7565705}") = "Fake.BuildServer.GitHubActions", "src\app\Fake.BuildServer.GitHubActions\Fake.BuildServer.GitHubActions.fsproj", "{AB09E8EB-A66E-4D60-B47C-4F35F439D020}"
EndProject
Project("{F2A71F9B-5D33-465A-A702-920D77279786}") = "Fake.Testing.Fixie", "src\app\Fake.Testing.Fixie\Fake.Testing.Fixie.fsproj", "{5FEC4AB5-D5EE-43B5-B176-0A91D951817A}"
Project("{6EC3EE1D-3C4E-46DD-8F32-0CC8E7565705}") = "Fake.Testing.Fixie", "src\app\Fake.Testing.Fixie\Fake.Testing.Fixie.fsproj", "{5FEC4AB5-D5EE-43B5-B176-0A91D951817A}"
EndProject
Project("{F2A71F9B-5D33-465A-A702-920D77279786}") = "Fake.BuildServer.Bitbucket", "src\app\Fake.BuildServer.Bitbucket\Fake.BuildServer.Bitbucket.fsproj", "{5472237F-020B-4F9A-8E06-01D553576387}"
Project("{6EC3EE1D-3C4E-46DD-8F32-0CC8E7565705}") = "Fake.BuildServer.Bitbucket", "src\app\Fake.BuildServer.Bitbucket\Fake.BuildServer.Bitbucket.fsproj", "{5472237F-020B-4F9A-8E06-01D553576387}"
EndProject
Project("{F2A71F9B-5D33-465A-A702-920D77279786}") = "Fake.JavaScript.TypeScript", "src\app\Fake.JavaScript.TypeScript\Fake.JavaScript.TypeScript.fsproj", "{1C476373-FF62-4EA7-8CCC-6A0D0DB96B6D}"
Project("{6EC3EE1D-3C4E-46DD-8F32-0CC8E7565705}") = "Fake.JavaScript.TypeScript", "src\app\Fake.JavaScript.TypeScript\Fake.JavaScript.TypeScript.fsproj", "{1C476373-FF62-4EA7-8CCC-6A0D0DB96B6D}"
EndProject
Project("{F2A71F9B-5D33-465A-A702-920D77279786}") = "Fake.DotNet.Fsdocs", "src\app\Fake.DotNet.Fsdocs\Fake.DotNet.Fsdocs.fsproj", "{6918A236-3F2A-47EA-9651-020522C48E24}"
Project("{6EC3EE1D-3C4E-46DD-8F32-0CC8E7565705}") = "Fake.DotNet.Fsdocs", "src\app\Fake.DotNet.Fsdocs\Fake.DotNet.Fsdocs.fsproj", "{6918A236-3F2A-47EA-9651-020522C48E24}"
EndProject
Global
GlobalSection(SolutionConfigurationPlatforms) = preSolution
Expand Down Expand Up @@ -637,42 +637,30 @@ Global
{D24CEE35-B6C0-4C92-AE18-E80F90B69974}.Release|x64.Build.0 = Release|Any CPU
{D24CEE35-B6C0-4C92-AE18-E80F90B69974}.Release|x86.ActiveCfg = Release|Any CPU
{D24CEE35-B6C0-4C92-AE18-E80F90B69974}.Release|x86.Build.0 = Release|Any CPU
{5B2A7546-A441-45C9-8176-2872E2A30477}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
{5B2A7546-A441-45C9-8176-2872E2A30477}.Debug|Any CPU.Build.0 = Debug|Any CPU
{5B2A7546-A441-45C9-8176-2872E2A30477}.Debug|x64.ActiveCfg = Debug|Any CPU
{5B2A7546-A441-45C9-8176-2872E2A30477}.Debug|x64.Build.0 = Debug|Any CPU
{5B2A7546-A441-45C9-8176-2872E2A30477}.Debug|x86.ActiveCfg = Debug|Any CPU
{5B2A7546-A441-45C9-8176-2872E2A30477}.Debug|x86.Build.0 = Debug|Any CPU
{5B2A7546-A441-45C9-8176-2872E2A30477}.Release|Any CPU.ActiveCfg = Release|Any CPU
{5B2A7546-A441-45C9-8176-2872E2A30477}.Release|Any CPU.Build.0 = Release|Any CPU
{5B2A7546-A441-45C9-8176-2872E2A30477}.Release|x64.ActiveCfg = Release|Any CPU
{5B2A7546-A441-45C9-8176-2872E2A30477}.Release|x64.Build.0 = Release|Any CPU
{5B2A7546-A441-45C9-8176-2872E2A30477}.Release|x86.ActiveCfg = Release|Any CPU
{5B2A7546-A441-45C9-8176-2872E2A30477}.Release|x86.Build.0 = Release|Any CPU
{E02F39E8-24E1-4210-A096-C4D7BDD22534}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
{E02F39E8-24E1-4210-A096-C4D7BDD22534}.Debug|Any CPU.Build.0 = Debug|Any CPU
{E02F39E8-24E1-4210-A096-C4D7BDD22534}.Debug|x64.ActiveCfg = Debug|Any CPU
{E02F39E8-24E1-4210-A096-C4D7BDD22534}.Debug|x64.Build.0 = Debug|Any CPU
{E02F39E8-24E1-4210-A096-C4D7BDD22534}.Debug|x86.ActiveCfg = Debug|Any CPU
{E02F39E8-24E1-4210-A096-C4D7BDD22534}.Debug|x86.Build.0 = Debug|Any CPU
{E02F39E8-24E1-4210-A096-C4D7BDD22534}.Release|Any CPU.ActiveCfg = Release|Any CPU
{E02F39E8-24E1-4210-A096-C4D7BDD22534}.Release|Any CPU.Build.0 = Release|Any CPU
{E02F39E8-24E1-4210-A096-C4D7BDD22534}.Release|x64.ActiveCfg = Release|Any CPU
{E02F39E8-24E1-4210-A096-C4D7BDD22534}.Release|x64.Build.0 = Release|Any CPU
{E02F39E8-24E1-4210-A096-C4D7BDD22534}.Release|x86.ActiveCfg = Release|Any CPU
{E02F39E8-24E1-4210-A096-C4D7BDD22534}.Release|x86.Build.0 = Release|Any CPU
{18C490E3-EA3F-4DC5-87A0-1A02309F8664}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
{18C490E3-EA3F-4DC5-87A0-1A02309F8664}.Debug|Any CPU.Build.0 = Debug|Any CPU
{18C490E3-EA3F-4DC5-87A0-1A02309F8664}.Debug|x64.ActiveCfg = Debug|Any CPU
{18C490E3-EA3F-4DC5-87A0-1A02309F8664}.Debug|x64.Build.0 = Debug|Any CPU
{18C490E3-EA3F-4DC5-87A0-1A02309F8664}.Debug|x86.ActiveCfg = Debug|Any CPU
{18C490E3-EA3F-4DC5-87A0-1A02309F8664}.Debug|x86.Build.0 = Debug|Any CPU
{18C490E3-EA3F-4DC5-87A0-1A02309F8664}.Release|Any CPU.ActiveCfg = Release|Any CPU
{18C490E3-EA3F-4DC5-87A0-1A02309F8664}.Release|Any CPU.Build.0 = Release|Any CPU
{18C490E3-EA3F-4DC5-87A0-1A02309F8664}.Release|x64.ActiveCfg = Release|Any CPU
{18C490E3-EA3F-4DC5-87A0-1A02309F8664}.Release|x64.Build.0 = Release|Any CPU
{18C490E3-EA3F-4DC5-87A0-1A02309F8664}.Release|x86.ActiveCfg = Release|Any CPU
{18C490E3-EA3F-4DC5-87A0-1A02309F8664}.Release|x86.Build.0 = Release|Any CPU
{5B2A7546-A441-45C9-8176-2872E2A30477}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
{5B2A7546-A441-45C9-8176-2872E2A30477}.Debug|Any CPU.Build.0 = Debug|Any CPU
{5B2A7546-A441-45C9-8176-2872E2A30477}.Debug|x64.ActiveCfg = Debug|Any CPU
{5B2A7546-A441-45C9-8176-2872E2A30477}.Debug|x64.Build.0 = Debug|Any CPU
{5B2A7546-A441-45C9-8176-2872E2A30477}.Debug|x86.ActiveCfg = Debug|Any CPU
{5B2A7546-A441-45C9-8176-2872E2A30477}.Debug|x86.Build.0 = Debug|Any CPU
{5B2A7546-A441-45C9-8176-2872E2A30477}.Release|Any CPU.ActiveCfg = Release|Any CPU
{5B2A7546-A441-45C9-8176-2872E2A30477}.Release|Any CPU.Build.0 = Release|Any CPU
{5B2A7546-A441-45C9-8176-2872E2A30477}.Release|x64.ActiveCfg = Release|Any CPU
{5B2A7546-A441-45C9-8176-2872E2A30477}.Release|x64.Build.0 = Release|Any CPU
{5B2A7546-A441-45C9-8176-2872E2A30477}.Release|x86.ActiveCfg = Release|Any CPU
{5B2A7546-A441-45C9-8176-2872E2A30477}.Release|x86.Build.0 = Release|Any CPU
{18C490E3-EA3F-4DC5-87A0-1A02309F8664}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
{18C490E3-EA3F-4DC5-87A0-1A02309F8664}.Debug|Any CPU.Build.0 = Debug|Any CPU
{18C490E3-EA3F-4DC5-87A0-1A02309F8664}.Debug|x64.ActiveCfg = Debug|Any CPU
{18C490E3-EA3F-4DC5-87A0-1A02309F8664}.Debug|x64.Build.0 = Debug|Any CPU
{18C490E3-EA3F-4DC5-87A0-1A02309F8664}.Debug|x86.ActiveCfg = Debug|Any CPU
{18C490E3-EA3F-4DC5-87A0-1A02309F8664}.Debug|x86.Build.0 = Debug|Any CPU
{18C490E3-EA3F-4DC5-87A0-1A02309F8664}.Release|Any CPU.ActiveCfg = Release|Any CPU
{18C490E3-EA3F-4DC5-87A0-1A02309F8664}.Release|Any CPU.Build.0 = Release|Any CPU
{18C490E3-EA3F-4DC5-87A0-1A02309F8664}.Release|x64.ActiveCfg = Release|Any CPU
{18C490E3-EA3F-4DC5-87A0-1A02309F8664}.Release|x64.Build.0 = Release|Any CPU
{18C490E3-EA3F-4DC5-87A0-1A02309F8664}.Release|x86.ActiveCfg = Release|Any CPU
{18C490E3-EA3F-4DC5-87A0-1A02309F8664}.Release|x86.Build.0 = Release|Any CPU
{31A5759B-B562-43C0-A845-14EFA4091543}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
{31A5759B-B562-43C0-A845-14EFA4091543}.Debug|Any CPU.Build.0 = Debug|Any CPU
{31A5759B-B562-43C0-A845-14EFA4091543}.Debug|x64.ActiveCfg = Debug|Any CPU
Expand Down Expand Up @@ -733,6 +721,18 @@ Global
{F15967FF-E905-4CAD-9545-E59E0F47AD8E}.Release|x64.Build.0 = Release|Any CPU
{F15967FF-E905-4CAD-9545-E59E0F47AD8E}.Release|x86.ActiveCfg = Release|Any CPU
{F15967FF-E905-4CAD-9545-E59E0F47AD8E}.Release|x86.Build.0 = Release|Any CPU
{E02F39E8-24E1-4210-A096-C4D7BDD22534}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
{E02F39E8-24E1-4210-A096-C4D7BDD22534}.Debug|Any CPU.Build.0 = Debug|Any CPU
{E02F39E8-24E1-4210-A096-C4D7BDD22534}.Debug|x64.ActiveCfg = Debug|Any CPU
{E02F39E8-24E1-4210-A096-C4D7BDD22534}.Debug|x64.Build.0 = Debug|Any CPU
{E02F39E8-24E1-4210-A096-C4D7BDD22534}.Debug|x86.ActiveCfg = Debug|Any CPU
{E02F39E8-24E1-4210-A096-C4D7BDD22534}.Debug|x86.Build.0 = Debug|Any CPU
{E02F39E8-24E1-4210-A096-C4D7BDD22534}.Release|Any CPU.ActiveCfg = Release|Any CPU
{E02F39E8-24E1-4210-A096-C4D7BDD22534}.Release|Any CPU.Build.0 = Release|Any CPU
{E02F39E8-24E1-4210-A096-C4D7BDD22534}.Release|x64.ActiveCfg = Release|Any CPU
{E02F39E8-24E1-4210-A096-C4D7BDD22534}.Release|x64.Build.0 = Release|Any CPU
{E02F39E8-24E1-4210-A096-C4D7BDD22534}.Release|x86.ActiveCfg = Release|Any CPU
{E02F39E8-24E1-4210-A096-C4D7BDD22534}.Release|x86.Build.0 = Release|Any CPU
{9EA0CFE4-ED50-4CB9-BE93-1AFB9D90C878}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
{9EA0CFE4-ED50-4CB9-BE93-1AFB9D90C878}.Debug|Any CPU.Build.0 = Debug|Any CPU
{9EA0CFE4-ED50-4CB9-BE93-1AFB9D90C878}.Debug|x64.ActiveCfg = Debug|Any CPU
Expand Down Expand Up @@ -1290,13 +1290,13 @@ Global
{13C1F95D-2FAD-4890-BF94-0AE7CF9AB2FC} = {7BFFAE76-DEE9-417A-A79B-6A6644C4553A}
{D24CEE35-B6C0-4C92-AE18-E80F90B69974} = {7BFFAE76-DEE9-417A-A79B-6A6644C4553A}
{5B2A7546-A441-45C9-8176-2872E2A30477} = {7BFFAE76-DEE9-417A-A79B-6A6644C4553A}
{E02F39E8-24E1-4210-A096-C4D7BDD22534} = {7BFFAE76-DEE9-417A-A79B-6A6644C4553A}
{18C490E3-EA3F-4DC5-87A0-1A02309F8664} = {7BFFAE76-DEE9-417A-A79B-6A6644C4553A}
{31A5759B-B562-43C0-A845-14EFA4091543} = {CCAC5CAB-03C8-4C11-ADBE-A0D05F6A4F18}
{D8850C67-0542-427A-ABCB-92174EA42C95} = {7BFFAE76-DEE9-417A-A79B-6A6644C4553A}
{8D72BED1-BC02-4B23-A631-4849BD0FD3E1} = {7BFFAE76-DEE9-417A-A79B-6A6644C4553A}
{A1CAA84D-3C99-4218-AFB6-55EE2288800E} = {7BFFAE76-DEE9-417A-A79B-6A6644C4553A}
{F15967FF-E905-4CAD-9545-E59E0F47AD8E} = {7BFFAE76-DEE9-417A-A79B-6A6644C4553A}
{E02F39E8-24E1-4210-A096-C4D7BDD22534} = {7BFFAE76-DEE9-417A-A79B-6A6644C4553A}
{9EA0CFE4-ED50-4CB9-BE93-1AFB9D90C878} = {7BFFAE76-DEE9-417A-A79B-6A6644C4553A}
{486FA49B-D395-42C5-AFB0-FA85B6D9FDBC} = {7BFFAE76-DEE9-417A-A79B-6A6644C4553A}
{31F61589-E899-4C58-AF91-371AC6149032} = {7BFFAE76-DEE9-417A-A79B-6A6644C4553A}
Expand Down
3 changes: 3 additions & 0 deletions RELEASE_NOTES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
# Release Notes
## 6.1.2 - 2024-09-03
* Added .NET8.0 to package target libraries
* Some dependency updates

## 6.1.1 - 2024-08-30
* BUGFIX: Assembly resolver to pick a found SDK instead of first SDK, thanks @Thorium - https://github.com/fsprojects/FAKE/pull/2797/files
Expand Down
22 changes: 13 additions & 9 deletions build.fsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,14 @@
// And to release do: dotnet fake run build.fsx -e configuration=Release -t Release

#r "paket:
source release/temp-recursion-break
source release/dotnetcore
source https://api.nuget.org/v3/index.json
nuget FSharp.Core
nuget Microsoft.Build 17.3.2
nuget Microsoft.Build.Framework 17.3.2
nuget Microsoft.Build.Tasks.Core 17.3.2
nuget Microsoft.Build.Utilities.Core 17.3.2
nuget Microsoft.Build 17.11.4
Copy link
Contributor

@Numpsy Numpsy Sep 15, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: Does it still need to reference all 4 of these Microsoft.Build packages here?

Older versions of MSBuild.StructuredLogger used to depend on all of these, but newer versions (including the 2.1.815 build currently used by Fake) only depend on Framework and Utilities.Core so I wonder if the base one and Tasks.Core can be removed now?

Same question about paket.dependencies too.

nuget Microsoft.Build.Framework 17.11.4
nuget Microsoft.Build.Tasks.Core 17.11.4
nuget Microsoft.Build.Utilities.Core 17.11.4
nuget System.AppContext prerelease
nuget Paket.Core prerelease
nuget Fake.Api.GitHub prerelease
Expand Down Expand Up @@ -41,7 +42,7 @@ nuget System.Reactive.Compatibility
nuget Suave
nuget Newtonsoft.Json
nuget System.Net.Http
nuget Octokit 6.0.0
nuget Octokit 13.0.1
nuget Microsoft.Deployment.DotNet.Releases //"

open System.Reflection
Expand Down Expand Up @@ -425,7 +426,7 @@ docker run --rm -v $PWD:$PWD -w $PWD linuturk/mono-choco $@
altToolPath

//TODO:: see if we need to update the runtimes to newer versions of OSs
let runtimes = [ "win7-x86"; "win7-x64"; "osx.10.11-x64"; "linux-x64" ]
let runtimes = [ "win-x86"; "win-x64"; "osx-x64"; "linux-x64" ]

/// <summary>
/// Publishes the build artifacts for the given runtime
Expand Down Expand Up @@ -775,7 +776,7 @@ Target.create "_DotNetPublish_portable" (fun _ ->
DotNet.publish
(fun c ->
{ c with
Framework = Some "net6.0"
Framework = Some "net8.0"
OutputPath = Some outDir }
|> dotnetSimple)
netcoreFsproj
Expand Down Expand Up @@ -809,7 +810,9 @@ runtimes
{ c with
Runtime = Some runtime.Value
Configuration = DotNet.Release
OutputPath = Some outDir }
OutputPath = Some outDir
Framework = Some "net8.0"
MSBuildParams = { MSBuild.CliArguments.Create() with DisableInternalBinLog = true }}
|> dotnetSimple)
proj

Expand Down Expand Up @@ -876,7 +879,8 @@ Target.create "DotNetCreateNuGetPackage" (fun _ ->
{ c.MSBuildParams with
Properties =
[ ("Version", nugetVersion)
("PackageReleaseNotes", release.Notes |> String.toLines) ] } }
("PackageReleaseNotes", release.Notes |> String.toLines) ]
DisableInternalBinLog = true } }
|> dotnetSimple)
"Fake.sln"

Expand Down
2 changes: 1 addition & 1 deletion global.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"sdk" : {
"version": "6.0.301",
"version": "8.0.304",
"rollForward": "latestMinor"
}
}
6 changes: 3 additions & 3 deletions paket.dependencies
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ group Build

group fakerunner
source https://api.nuget.org/v3/index.json
framework: net472, netstandard2.0, netcoreapp2.1, net6.0
framework: net472, netstandard2.0, netstandard2.1, netcoreapp2.1, net6.0, net8.0
storage: none

nuget FSharp.Core
Expand All @@ -45,7 +45,7 @@ group fakerunner

group fakemodule
source https://api.nuget.org/v3/index.json
framework: net472, netstandard2.0, netcoreapp2.1, net6.0
framework: net472, netstandard2.0, netstandard2.1, netcoreapp2.1, net6.0, net8.0
storage: none

nuget DotNet.Xdt
Expand All @@ -69,4 +69,4 @@ group fakemodule
nuget BlackFox.VsWhere
nuget System.Runtime.Loader
nuget System.Collections.Immutable
nuget System.Data.SqlClient
nuget System.Data.SqlClient
Loading
Loading