Small memory and performance optimization: Less nested seq-wrapping on recursive functions #1511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you run |
|
Thanks, done, I didn't know Fantomas had infected this repo as well. |
|
I'd also like to get this change for FSharp.Data now that it's F# 6: |
|
Mmm, this change causes a stack overflow when generating docs. Could you investigate? https://github.com/fsprojects/FSharp.Data/actions/runs/9828724527/job/27132994427?pr=1511#step:6:1748 |
|
Ok, fixed. The docs were actually nice edge-case unit-tests. :-) |
cartermp
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small memory and performance optimization:
As a side note:
There are some cases where FSharp.Data does some manual recursive string-parsing-functions. More could be done on those: If we'd accept a new dependency to System.Memory on .NET Standard 2.0 version, we'd get
.AsSpanandReadOnlySpan<char>which could be used to gain speed and save memory (especially on .NET Standard 2.1 where those are available out-of-the-box and System.Memory reference is not needed).