Merge pull request #950 from MangelMaxime/fix/duplicate_member_extension

fix: remove duplicated `Type Extensions`
fsprojects · Jan 3, 2025 · 7b20db4 · 7b20db4
2 parents ae05ce5 + 532007c
commit 7b20db4
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/src/FSharp.Formatting.ApiDocs/GenerateModel.fs b/src/FSharp.Formatting.ApiDocs/GenerateModel.fs
@@ -2737,6 +2737,11 @@ module internal SymbolReader =
             let exts, nsdocs2 =
                 readMembers ctx entityUrl ApiDocMemberKind.TypeExtension modul (fun v -> v.IsExtensionMember)
 
+            // `with get and set` syntax is sugar for a mutable field, a get binding and a set binding
+            // This result in duplicated Method Extensions, we use DeclarationLocation to keep only one
+            // See https://github.com/fsprojects/FSharp.Formatting/issues/941
+            let exts = exts |> List.distinctBy (fun m -> m.Symbol.DeclarationLocation)
+
             let pats, nsdocs3 =
                 readMembers ctx entityUrl ApiDocMemberKind.ActivePattern modul (fun v -> v.IsActivePattern)