Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deal with F# 9 #3118

Merged
merged 23 commits into from
Sep 16, 2024
Merged

Deal with F# 9 #3118

merged 23 commits into from
Sep 16, 2024

Conversation

nojaf
Copy link
Contributor

@nojaf nojaf commented Sep 13, 2024

So, F# 9 is coming in November!

There are some new syntax features that we don't support yet:

In this PR, I'm updating the compiler (syncing the source dependency) and making the bare minimum adjustments to support the new syntax. This means I'm not focusing on style and will be winging it based on best effort.

To-do:

  • Pass all existing tests
  • Nullness tests
  • Access modifiers for auto-properties' getters and setters tests
  • Sanity check: format dotnet/fsharp to ensure everything is okay

Open questions:

  • I would like to bump FSharp.Core and StreamJsonRpc, but I'm unsure of the consequences. I'm most concerned about Update FSharp.Core fantomas-for-vs#55.
  • We should probably aim for a major version bump here and increase the TFM of the tool to net8.0.
  • Should we reconsider anything else if we proceed with a major version bump?

Follow up:

//cc @dawedawe @josh-degraw

@nojaf
Copy link
Contributor Author

nojaf commented Sep 13, 2024

Not sure why, but the logger was no longer printing anything to the stdout.
No clue why, but using the static logger works.

@nojaf nojaf requested a review from dawedawe September 13, 2024 13:59
Copy link
Member

@dawedawe dawedawe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the name of all Fantomas users: Thank you!

src/Fantomas.Core/ASTTransformer.fs Outdated Show resolved Hide resolved
src/Fantomas.Core/ASTTransformer.fs Outdated Show resolved Hide resolved
@nojaf nojaf changed the base branch from main to v7 September 16, 2024 12:18
@nojaf nojaf marked this pull request as ready for review September 16, 2024 12:27
@nojaf nojaf merged commit 88cb207 into fsprojects:v7 Sep 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants