User activation logic and UI. r=fabrice #526
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferjm
force-pushed
the
user.activation.ui
branch
from
1220410
to
5ffebcf
Compare
ferjm
changed the title
|
We need to merge https://github.com/fxbox/users/pull/87/files and change the dependency url before merging this one. |
|
lgtm. I wonder if we could give users some hint that they need to be on the same network when accessing the validation link. |
|
Absolutely. We need some UX input about what to send in the invitation email. We can send a different email body depending on the tunnel status. I'll file an issue for that. Thanks! |
ferjm
force-pushed
the
user.activation.ui
branch
from
77ae4a1
to
3d785cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.