Fix: sprite disable batching when pick

[JujieX]

Please check if the PR fulfills these requirements

• The commit message follows our guidelines
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

disable sprite batching when pick

resolve #295

Summary by CodeRabbit

• New Features
  • Enhanced shader management by adding functionality for handling sub-shaders, allowing for more precise control over rendering configurations.
  • Introduced the ability to disable sprite batching for individual shader passes.

[coderabbitai]

Walkthrough

The recent changes to the FramebufferPicker module enhance shader management by introducing functionality for sub-shaders. A new loop iterates over the subShaders of the pickShader object, applying a tag to disable sprite batching for each pass. This adjustment allows for more precise control over how these shaders interact with the rendering pipeline, ultimately improving rendering configurations.

Changes

File Path	Change Summary
packages/framebuffer-picker/src/FramebufferPicker.ts	Added a loop to apply the "spriteDisableBatching" tag to each pass of the subShaders in pickShader, enhancing shader behavior in rendering.

Poem

In the land of shaders, where colors blend,
A rabbit hops forth, with changes to lend.
"Disable the batching! Let sprites dance free,
In the canvas of magic, just wait and see!"
With a flick of my ears and a joyful cheer,
Rendering's brighter, the future is clear! 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between d45e458 and 7104ce7.

Files selected for processing (1)

• packages/framebuffer-picker/src/FramebufferPicker.ts (2 hunks)

Additional comments not posted (1)

packages/framebuffer-picker/src/FramebufferPicker.ts (1)

22-26: LGTM! But verify the performance impact.

The code correctly iterates over subShaders and sets the tag spriteDisableBatching to true for each pass.

However, ensure that this change does not introduce any unintended side effects or performance issues.