Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge dev/1.3 Updates into Main Branch #300

Merged
merged 39 commits into from
Aug 2, 2024

Conversation

JujieX
Copy link
Member

@JujieX JujieX commented Aug 2, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:

Summary by CodeRabbit

  • New Features

    • Updated multiple packages to new beta versions, providing access to improved functionality and features.
    • Introduced new shaders for rendering realistic human eyes, hair, skin, and various other visual effects.
    • Added shader registration capabilities for better shader management.
  • Bug Fixes

    • Improved compatibility by aligning peer dependencies across various packages.
  • Documentation

    • Updated comments and structure in shader files for improved clarity and usability.
  • Chores

    • General updates in package versioning to reflect the transition to beta releases across the toolkit.

zhuxudong and others added 30 commits July 18, 2024 03:29
* feat: open shader core API by ShaderLab
# Conflicts:
#	packages/auxiliary-lines/package.json
#	packages/controls/package.json
#	packages/custom-gltf-parser/package.json
#	packages/custom-material/package.json
#	packages/draco/package.json
#	packages/dynamic-bone/package.json
#	packages/framebuffer-picker/package.json
#	packages/galacean-engine-toolkit/package.json
#	packages/geometry-sketch/package.json
#	packages/gizmo/package.json
#	packages/input-logger/package.json
#	packages/lines/package.json
#	packages/navigation-gizmo/package.json
#	packages/outline/package.json
#	packages/shaderlab/package.json
#	packages/shaderlab/src/GSLPBRMaterial.ts
#	packages/shaderlab/src/shaders/color_vert.glsl
#	packages/skeleton-viewer/package.json
#	packages/stats/package.json
#	packages/tween/package.json
#	packages/way-point/package.json
* refactor: Split Indirect LightProbe.glsl
* feat: digtal humen shader

* feat: add thin flim shader
* refactor: fix eye bug
fix: FlipY grid shader when `context.flipProjection === true`
…-ignore-postprocess

fix: ignore post-processing when framebuffer-picking
@JujieX JujieX requested a review from gz65555 August 2, 2024 04:24
Copy link

coderabbitai bot commented Aug 2, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

In this update, the @galacean/engine and its related toolkit packages have transitioned from alpha to beta versions, allowing for improved compatibility and new features. This change signifies a broader adoption of the toolkit, with multiple packages reflecting their alignment with the updated core engine. Additionally, several new shaders have been introduced, enhancing the graphical capabilities within the toolkit.

Changes

Files Change Summary
package.json Updated @galacean/engine version from ^1.2.0-alpha.5 to ^1.3.0-beta.6
packages/*/package.json Incremented package versions from 1.2.0 to 1.3.0-beta.2 and updated peer dependencies for @galacean/engine to ^1.3.0-beta.6
packages/custom-material/src/advanced-shader/eye/Eye.gs New shader for rendering human eyes with customizable properties.
packages/custom-material/src/advanced-shader/hair/Hair.gs New shader designed for hair rendering.
packages/custom-material/src/advanced-shader/sss/SSS.gs New shader for rendering skin with subsurface scattering effects.
packages/shaderlab/src/index.ts Added functions for shader registration: registerIncludes and registerShader.
packages/shaderlab/src/shaders/*.glsl Introduced multiple new shader files (e.g., BlendShape.glsl, PBR.gs) and enhanced existing shaders with new functionalities.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Toolkit
    participant Shaders

    User->>Toolkit: Request for rendering
    Toolkit->>Shaders: Use shaders for rendering
    Shaders->>User: Rendered output
Loading

Poem

🐰 In the garden where colors bloom,
A toolkit grows, dispelling gloom.
With shaders bright and features new,
The rabbit hops, and so should you!
Let's celebrate with joyful cheer,
For beta's here, the time is near! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@JujieX JujieX merged commit 2ca0822 into galacean:main Aug 2, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants