Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gltf Iridescence #2425

Open
wants to merge 37 commits into
base: dev/1.4
Choose a base branch
from

ci: prettier code

f4b16fd
Select commit
Loading
Failed to load commit list.
Open

Gltf Iridescence #2425

ci: prettier code
f4b16fd
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Nov 12, 2024 in 0s

66.81% (-0.04%) compared to 4fe788f

View this Pull Request on Codecov

66.81% (-0.04%) compared to 4fe788f

Details

Codecov Report

Attention: Patch coverage is 45.32374% with 76 lines in your changes missing coverage. Please review.

Project coverage is 66.81%. Comparing base (4fe788f) to head (f4b16fd).

Files with missing lines Patch % Lines
packages/core/src/material/PBRMaterial.ts 52.52% 47 Missing ⚠️
...r/src/gltf/extensions/KHR_materials_iridescence.ts 27.50% 29 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           dev/1.4    #2425      +/-   ##
===========================================
- Coverage    66.84%   66.81%   -0.04%     
===========================================
  Files          895      896       +1     
  Lines        92100    92238     +138     
  Branches      7327     7328       +1     
===========================================
+ Hits         61565    61625      +60     
- Misses       30290    30368      +78     
  Partials       245      245              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.