Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gltf Iridescence #2425

Open
wants to merge 37 commits into
base: dev/1.4
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 35 commits
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
5a26f3d
fix(shader-lab): compatible with empty macro
Sway007 Sep 20, 2023
5ecc318
Merge branch 'main' of https://github.com/galacean/engine
Sway007 Sep 20, 2023
cafc24f
Merge branch 'main' of https://github.com/galacean/engine
Sway007 Sep 20, 2023
dc69489
Merge branch 'main' of https://github.com/galacean/engine
Sway007 Sep 21, 2023
221b7b6
Merge branch 'main' of https://github.com/galacean/engine
Sway007 Sep 21, 2023
0d45d9c
fix(shader-lab): add break and continue syntax
Sway007 Sep 21, 2023
0f14c3f
Merge branch 'main' of https://github.com/galacean/engine
Sway007 Sep 27, 2023
8871d9b
fix: typo
Sway007 Oct 11, 2023
3b4ffd7
Merge branch 'main' of https://github.com/galacean/engine
Sway007 Nov 1, 2023
f649a58
fix(shader-lab): Make usepass compatible with buitin shader
Sway007 Nov 1, 2023
598fc56
Merge branch 'main' of https://github.com/galacean/engine
Sway007 Nov 2, 2023
e33a66f
fix(shader-lab): compatible with no varying variable
Sway007 Nov 2, 2023
41ef06f
feat(shader-lab): detect mismatch return type
Sway007 Nov 6, 2023
b5214fc
fix(shader-lab): renderState assignment
Sway007 Nov 7, 2023
f36ce02
feat: extend material loader data type
Sway007 Nov 13, 2023
ff8b7c2
Merge branch 'main' of https://github.com/galacean/engine
Sway007 Nov 13, 2023
634236f
fix(shader-lab): glsl type pattern
Sway007 Nov 13, 2023
91e6fa4
fix(shader-lab): glsl type pattern
Sway007 Nov 13, 2023
3932448
fix: switch case break
Sway007 Nov 15, 2023
671cace
fix: array index loss
Sway007 Jun 11, 2024
92b972e
feat: merge
Sway007 Jun 11, 2024
9226d38
fix: test-case
Sway007 Jun 11, 2024
ff6a69a
fix: test-case
Sway007 Jun 12, 2024
0838968
feat: support GLTF_Iridescence
hhhhkrx Nov 6, 2024
82d5a8f
Merge branch 'main' of github.com:galacean/engine into gltf_iridescence
hhhhkrx Nov 6, 2024
39043a2
fix: merge
hhhhkrx Nov 6, 2024
ad61eed
Merge branch 'dev/1.4' of github.com:galacean/engine into gltf_irides…
hhhhkrx Nov 6, 2024
2b308ec
fix: vector3
hhhhkrx Nov 6, 2024
2c1604f
fix: vector3
hhhhkrx Nov 6, 2024
0be9f2a
fix: texture name
hhhhkrx Nov 6, 2024
88f89f2
Merge branch 'dev/1.4' into gltf_iridescence
hhhhkrx Nov 6, 2024
b5b9a0a
fix: material uniform
hhhhkrx Nov 7, 2024
d7a82de
fix: enable iridescence
hhhhkrx Nov 7, 2024
d1547d4
Merge branch 'dev/1.4' of github.com:galacean/engine into gltf_irides…
hhhhkrx Nov 11, 2024
76c5423
fix: iridescence name
hhhhkrx Nov 11, 2024
aa41aaf
fix: add }
hhhhkrx Nov 11, 2024
f4b16fd
ci: prettier code
hhhhkrx Nov 12, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
101 changes: 100 additions & 1 deletion packages/core/src/material/PBRMaterial.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { MathUtil, Vector3 } from "@galacean/engine-math";
import { MathUtil, Vector3, Vector4 } from "@galacean/engine-math";
import { Engine } from "../Engine";
import { ShaderProperty } from "../shader";
import { Shader } from "../shader/Shader";
Expand All @@ -20,6 +20,10 @@ export class PBRMaterial extends PBRBaseMaterial {

private _anisotropyRotation: number = 0;

private static _iridescenceInfoProp = ShaderProperty.getByName("material_IridescenceInfo");
private static _iridescenceThicknessTextureProp = ShaderProperty.getByName("material_IridescenceThicknessTexture");
private static _iridescenceTextureProp = ShaderProperty.getByName("material_IridescenceTexture");

/**
* Index Of Refraction.
* @defaultValue `1.5`
Expand Down Expand Up @@ -132,6 +136,99 @@ export class PBRMaterial extends PBRBaseMaterial {
}
}

/**
* The iridescence intensity factor.
* @defaultValue `0.0`
*/
get iridescenceFactor(): number {
return this.shaderData.getVector4(PBRMaterial._iridescenceInfoProp).x;
}

set iridescenceFactor(value: number) {
const iridescenceInfo = this.shaderData.getVector4(PBRMaterial._iridescenceInfoProp);
if (!!iridescenceInfo.x !== !!value) {
if (value === 0) {
this.shaderData.disableMacro("MATERIAL_ENABLE_IRIDESCENCE");
} else {
this.shaderData.enableMacro("MATERIAL_ENABLE_IRIDESCENCE");
}
iridescenceInfo.x = value;
}

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Fix iridescence factor implementation.

There are two issues in the implementation:

  1. The value should be clamped to [0,1] range as it represents an intensity factor
  2. The value is set after the macro check, which could lead to inconsistent state

Apply this diff to fix both issues:

  set iridescenceFactor(value: number) {
    const iridescenceInfo = this.shaderData.getVector4(PBRMaterial._iridescenceInfoProp);
+   value = Math.max(0, Math.min(1, value));
    if (!!iridescenceInfo.x !== !!value) {
      if (value === 0) {
        this.shaderData.disableMacro("MATERIAL_ENABLE_IRIDESCENCE");
      } else {
        this.shaderData.enableMacro("MATERIAL_ENABLE_IRIDESCENCE");
      }
-     iridescenceInfo.x = value;
    }
+   iridescenceInfo.x = value;
  }
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
set iridescenceFactor(value: number) {
const iridescenceInfo = this.shaderData.getVector4(PBRMaterial._iridescenceInfoProp);
if (!!iridescenceInfo.x !== !!value) {
if (value === 0) {
this.shaderData.disableMacro("MATERIAL_ENABLE_IRIDESCENCE");
} else {
this.shaderData.enableMacro("MATERIAL_ENABLE_IRIDESCENCE");
}
iridescenceInfo.x = value;
}
set iridescenceFactor(value: number) {
const iridescenceInfo = this.shaderData.getVector4(PBRMaterial._iridescenceInfoProp);
value = Math.max(0, Math.min(1, value));
if (!!iridescenceInfo.x !== !!value) {
if (value === 0) {
this.shaderData.disableMacro("MATERIAL_ENABLE_IRIDESCENCE");
} else {
this.shaderData.enableMacro("MATERIAL_ENABLE_IRIDESCENCE");
}
}
iridescenceInfo.x = value;
}

/**
* The index of refraction of the dielectric thin-film layer.
* @defaultValue `1.3`
*/
get iridescenceIor(): number {
return this.shaderData.getVector4(PBRMaterial._iridescenceInfoProp).y;
}

set iridescenceIor(value: number) {
const iridescenceInfo = this.shaderData.getVector4(PBRMaterial._iridescenceInfoProp);
iridescenceInfo.y = value;
}

Comment on lines +167 to +170
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Add validation for iridescence IOR.

The index of refraction must be greater than 1.0 as it represents a physical property.

Apply this diff to add validation:

  set iridescenceIor(value: number) {
    const iridescenceInfo = this.shaderData.getVector4(PBRMaterial._iridescenceInfoProp);
+   value = Math.max(1.0, value);
    iridescenceInfo.y = value;
  }
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
set iridescenceIor(value: number) {
const iridescenceInfo = this.shaderData.getVector4(PBRMaterial._iridescenceInfoProp);
iridescenceInfo.y = value;
}
set iridescenceIor(value: number) {
const iridescenceInfo = this.shaderData.getVector4(PBRMaterial._iridescenceInfoProp);
value = Math.max(1.0, value);
iridescenceInfo.y = value;
}
🧰 Tools
🪛 Biome

[error] 166-166: Expected a semicolon or an implicit semicolon after a statement, but found none

An explicit or implicit semicolon is expected here...

...Which is required to end this statement

(parse)


[error] 166-166: expected , but instead found :

Remove :

(parse)


[error] 166-166: Expected a semicolon or an implicit semicolon after a statement, but found none

An explicit or implicit semicolon is expected here...

...Which is required to end this statement

(parse)


[error] 166-175: This code is unreachable

... because this statement will return from the function beforehand

(lint/correctness/noUnreachable)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Add validation for iridescence IOR.

The index of refraction must be greater than 1.0 as it represents a physical property.

Apply this diff to add validation:

  set iridescenceIor(value: number) {
    const iridescenceInfo = this.shaderData.getVector4(PBRMaterial._iridescenceInfoProp);
+   value = Math.max(1.0, value);
    iridescenceInfo.y = value;
  }

Would you like me to help generate unit tests for this property?

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
/**
* The index of refraction of the dielectric thin-film layer.
* @defaultValue `1.3`
*/
get iridescenceIor(): number {
return this.shaderData.getVector4(PBRMaterial._iridescenceInfoProp).y;
}
set iridescenceIor(value: number) {
const iridescenceInfo = this.shaderData.getVector4(PBRMaterial._iridescenceInfoProp);
iridescenceInfo.y = value;
}
/**
* The index of refraction of the dielectric thin-film layer.
* @defaultValue `1.3`
*/
get iridescenceIor(): number {
return this.shaderData.getVector4(PBRMaterial._iridescenceInfoProp).y;
}
set iridescenceIor(value: number) {
const iridescenceInfo = this.shaderData.getVector4(PBRMaterial._iridescenceInfoProp);
value = Math.max(1.0, value);
iridescenceInfo.y = value;
}
🧰 Tools
🪛 eslint

[error] 160-160: Delete

(prettier/prettier)

🪛 GitHub Check: codecov/patch

[warning] 164-165: packages/core/src/material/PBRMaterial.ts#L164-L165
Added lines #L164 - L165 were not covered by tests


[warning] 168-170: packages/core/src/material/PBRMaterial.ts#L168-L170
Added lines #L168 - L170 were not covered by tests

🪛 GitHub Check: lint

[failure] 160-160:
Delete

/**
* The minimum thickness of the thin-film layer given in nanometers.
* @defaultValue `100`
*/
get iridescenceThicknessMin(): number {
return this.shaderData.getVector4(PBRMaterial._iridescenceInfoProp).z;

}

set iridescenceThicknessMin(value: number) {
const iridescenceInfo = this.shaderData.getVector4(PBRMaterial._iridescenceInfoProp);
iridescenceInfo.z = value;
}

/**
* The maximum thickness of the thin-film layer given in nanometers.
* @defaultValue `400`
*/
get iridescenceThicknessMax(): number {
return this.shaderData.getVector4(PBRMaterial._iridescenceInfoProp).w;
}

set iridescenceThicknessMax(value: number) {
const iridescenceInfo = this.shaderData.getVector4(PBRMaterial._iridescenceInfoProp);
iridescenceInfo.w = value;
}

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Add validation for thickness values.

The thickness values need validation to ensure:

  1. Non-negative values (physical constraint)
  2. Minimum thickness is less than maximum thickness

Apply this diff to add validation:

  set iridescenceThicknessMin(value: number) {
    const iridescenceInfo = this.shaderData.getVector4(PBRMaterial._iridescenceInfoProp);
+   value = Math.max(0, value);
+   const maxThickness = iridescenceInfo.w;
+   if (value >= maxThickness) {
+     value = maxThickness * 0.9; // Ensure min is less than max
+   }
    iridescenceInfo.z = value;
  }

  set iridescenceThicknessMax(value: number) {
    const iridescenceInfo = this.shaderData.getVector4(PBRMaterial._iridescenceInfoProp);
+   value = Math.max(0, value);
+   const minThickness = iridescenceInfo.z;
+   if (value <= minThickness) {
+     value = minThickness * 1.1; // Ensure max is greater than min
+   }
    iridescenceInfo.w = value;
  }
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
set iridescenceThicknessMin(value: number) {
const iridescenceInfo = this.shaderData.getVector4(PBRMaterial._iridescenceInfoProp);
iridescenceInfo.z = value;
}
/**
* The maximum thickness of the thin-film layer given in nanometers.
* @defaultValue `400`
*/
get iridescenceThicknessMax(): number {
return this.shaderData.getVector4(PBRMaterial._iridescenceInfoProp).w;
}
set iridescenceThicknessMax(value: number) {
const iridescenceInfo = this.shaderData.getVector4(PBRMaterial._iridescenceInfoProp);
iridescenceInfo.w = value;
}
set iridescenceThicknessMin(value: number) {
const iridescenceInfo = this.shaderData.getVector4(PBRMaterial._iridescenceInfoProp);
value = Math.max(0, value);
const maxThickness = iridescenceInfo.w;
if (value >= maxThickness) {
value = maxThickness * 0.9; // Ensure min is less than max
}
iridescenceInfo.z = value;
}
/**
* The maximum thickness of the thin-film layer given in nanometers.
* @defaultValue `400`
*/
get iridescenceThicknessMax(): number {
return this.shaderData.getVector4(PBRMaterial._iridescenceInfoProp).w;
}
set iridescenceThicknessMax(value: number) {
const iridescenceInfo = this.shaderData.getVector4(PBRMaterial._iridescenceInfoProp);
value = Math.max(0, value);
const minThickness = iridescenceInfo.z;
if (value <= minThickness) {
value = minThickness * 1.1; // Ensure max is greater than min
}
iridescenceInfo.w = value;
}
🧰 Tools
🪛 Biome

[error] 180-180: Expected a semicolon or an implicit semicolon after a statement, but found none

An explicit or implicit semicolon is expected here...

...Which is required to end this statement

(parse)


[error] 180-180: expected , but instead found :

Remove :

(parse)


[error] 180-180: Expected a semicolon or an implicit semicolon after a statement, but found none

An explicit or implicit semicolon is expected here...

...Which is required to end this statement

(parse)


[error] 189-189: Expected a semicolon or an implicit semicolon after a statement, but found none

An explicit or implicit semicolon is expected here...

...Which is required to end this statement

(parse)


[error] 189-189: Expected a semicolon or an implicit semicolon after a statement, but found none

An explicit or implicit semicolon is expected here...

...Which is required to end this statement

(parse)


[error] 193-193: Expected a semicolon or an implicit semicolon after a statement, but found none

An explicit or implicit semicolon is expected here...

...Which is required to end this statement

(parse)


[error] 193-193: expected , but instead found :

Remove :

(parse)


[error] 193-193: Expected a semicolon or an implicit semicolon after a statement, but found none

An explicit or implicit semicolon is expected here...

...Which is required to end this statement

(parse)


[error] 190-190: The setter should not return a value.

The setter is here:

Returning a value from a setter is ignored.

(lint/correctness/noSetterReturn)


[error] 189-191: This block statement doesn't serve any purpose and can be safely removed.

Standalone block statements without any block-level declarations are redundant in JavaScript and can be removed to simplify the code.
Safe fix: Remove redundant block.

(lint/complexity/noUselessLoneBlockStatements)

/**
* The thickness texture of the thin-film layer.
*/
get iridescenceThicknessTexture(): Texture2D {
return <Texture2D>this.shaderData.getTexture(PBRMaterial._iridescenceThicknessTextureProp);
}

set iridescenceThicknessTexture(value: Texture2D) {
this.shaderData.setTexture(PBRMaterial._iridescenceThicknessTextureProp, value);

if (value) {
this.shaderData.enableMacro("MATERIAL_HAS_IRIDESCENCE_THICKNESS_TEXTURE");
} else {
this.shaderData.disableMacro("MATERIAL_HAS_IRIDESCENCE_THICKNESS_TEXTURE");
}
}

/**
* The iridescence intensity texture.
*/
get iridescenceTexture(): Texture2D {
return <Texture2D>this.shaderData.getTexture(PBRMaterial._iridescenceTextureProp);
}

set iridescenceTexture(value: Texture2D) {
this.shaderData.setTexture(PBRMaterial._iridescenceTextureProp, value);

if (value) {
this.shaderData.enableMacro("MATERIAL_HAS_IRIDESCENCE_TEXTURE");
} else {
this.shaderData.disableMacro("MATERIAL_HAS_IRIDESCENCE_TEXTURE");
}
}

/**
* Create a pbr metallic-roughness workflow material instance.
* @param engine - Engine to which the material belongs
Expand All @@ -144,6 +241,8 @@ export class PBRMaterial extends PBRBaseMaterial {
shaderData.setFloat(PBRMaterial._roughnessProp, 1);
shaderData.setFloat(PBRMaterial._iorProp, 1.5);
shaderData.setVector3(PBRMaterial._anisotropyInfoProp, new Vector3(1, 0, 0));
shaderData.setVector4(PBRMaterial._iridescenceInfoProp, new Vector4(0, 1.3, 100, 400));

}

/**
Expand Down
23 changes: 18 additions & 5 deletions packages/loader/src/gltf/extensions/GLTFExtensionSchema.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,11 @@ export interface IKHRLightsPunctual {
* Interfaces from the KHR_materials_clearcoat extension
*/
export interface IKHRMaterialsClearcoat {
clearcoatFactor: number;
clearcoatTexture: ITextureInfo;
clearcoatRoughnessFactor: number;
clearcoatRoughnessTexture: ITextureInfo;
clearcoatNormalTexture: IMaterialNormalTextureInfo;
clearcoatFactor?: number;
clearcoatTexture?: ITextureInfo;
clearcoatRoughnessFactor?: number;
clearcoatRoughnessTexture?: ITextureInfo;
clearcoatNormalTexture?: IMaterialNormalTextureInfo;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

}

/**
Expand Down Expand Up @@ -176,6 +176,18 @@ export interface IGalaceanAnimation {
}[];
}

/**
* Interfaces from the KHR_materials_iridescence extension
*/
export interface IKHRMaterialsIridescence {
iridescenceFactor?: number;
iridescenceTexture?: ITextureInfo;
iridescenceIor?: number;
iridescenceThicknessMinimum?: number;
iridescenceThicknessMaximum?: number;
iridescenceThicknessTexture?: ITextureInfo;
}

export type GLTFExtensionSchema =
| IKHRLightsPunctual_Light
| IKHRMaterialsClearcoat
Expand All @@ -194,4 +206,5 @@ export type GLTFExtensionSchema =
| IKHRXmp
| IKHRXmp_Node
| IGalaceanAnimation
| IKHRMaterialsIridescence
| Object;
40 changes: 40 additions & 0 deletions packages/loader/src/gltf/extensions/KHR_materials_iridescence.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
import { PBRMaterial, Texture2D } from "@galacean/engine-core";
import { GLTFMaterialParser } from "../parser/GLTFMaterialParser";
import { registerGLTFExtension } from "../parser/GLTFParser";
import { GLTFParserContext, GLTFParserType } from "../parser/GLTFParserContext";
import { GLTFExtensionMode, GLTFExtensionParser } from "./GLTFExtensionParser";
import { IKHRMaterialsIridescence } from "./GLTFExtensionSchema";

@registerGLTFExtension("KHR_materials_iridescence", GLTFExtensionMode.AdditiveParse)
class KHR_materials_iridescence extends GLTFExtensionParser {
override additiveParse(context: GLTFParserContext, material: PBRMaterial, schema: IKHRMaterialsIridescence): void {
const {
iridescenceFactor = 0,
iridescenceTexture,
iridescenceIor = 1.3,
iridescenceThicknessMinimum = 100,
iridescenceThicknessMaximum = 400,
iridescenceThicknessTexture
} = schema;

material.iridescenceFactor = iridescenceFactor;

Check failure on line 20 in packages/loader/src/gltf/extensions/KHR_materials_iridescence.ts

View workflow job for this annotation

GitHub Actions / lint

Delete `·`
material.iridescenceIor = iridescenceIor;

Check failure on line 21 in packages/loader/src/gltf/extensions/KHR_materials_iridescence.ts

View workflow job for this annotation

GitHub Actions / lint

Delete `·`
material.iridescenceThicknessMin = iridescenceThicknessMinimum;

Check failure on line 22 in packages/loader/src/gltf/extensions/KHR_materials_iridescence.ts

View workflow job for this annotation

GitHub Actions / lint

Delete `·`
material.iridescenceThicknessMax = iridescenceThicknessMaximum;

Check failure on line 23 in packages/loader/src/gltf/extensions/KHR_materials_iridescence.ts

View workflow job for this annotation

GitHub Actions / lint

Delete `·`

Check failure on line 24 in packages/loader/src/gltf/extensions/KHR_materials_iridescence.ts

View workflow job for this annotation

GitHub Actions / lint

Delete `·`
if (iridescenceTexture) {
GLTFMaterialParser._checkOtherTextureTransform(iridescenceTexture, "Iridescence texture");

context.get<Texture2D>(GLTFParserType.Texture, iridescenceTexture.index).then((texture) => {
material.iridescenceTexture = texture;
});
}
Comment on lines +28 to +31
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Add error handling for texture loading

The async texture loading should include error handling to prevent silent failures.

 context.get<Texture2D>(GLTFParserType.Texture, iridescenceTexture.index).then((texture) => {
   material.iridescenceTexture = texture;
-});
+}).catch((error) => {
+  console.warn(`Failed to load iridescence texture: ${error.message}`);
+});

 // Similar change for iridescenceThicknessTexture

Also applies to: 35-38

if (iridescenceThicknessTexture) {
GLTFMaterialParser._checkOtherTextureTransform(iridescenceThicknessTexture, "IridescenceThickness texture");

context.get<Texture2D>(GLTFParserType.Texture, iridescenceThicknessTexture.index).then((texture) => {
material.iridescenceThicknessTexture = texture;
});
}
}
}
1 change: 1 addition & 0 deletions packages/loader/src/gltf/extensions/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import "./GALACEAN_materials_remap";
import "./GALACEAN_animation_event";
import "./EXT_meshopt_compression";
import "./KHR_materials_anisotropy";
import "./KHR_materials_iridescence";
import "./EXT_texture_webp";

export { GLTFExtensionParser, GLTFExtensionMode } from "./GLTFExtensionParser";
Expand Down
Loading