Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add check before performing chmod on the code coverage path #262

Merged

Conversation

QuakeEye
Copy link
Contributor

Add check before performing chmod on the code coverage path, as it does not exist if the Code Coverage package is not installed, or is not set up correctly.

This was previously not done, causing me to spend a lot of time on trying to figure out why the action did not function as I expected it to.
I have also added a general message that gives some hints as to why the code coverage retrieval might not work.

Changes

  • Added a check before performing chmod on the expected code coverage report path
  • Added a general message to guide users when the path does not exist

Related Issues

Related PRs

  • none

Successful Workflow Run Link

PRs don't have access to secrets so you will need to provide a link to a successful run
of the workflows from your own repo.

Checklist

  • Read the contribution guide and accept the code of conduct
  • Docs (If new inputs or outputs have been added or changes to behavior that should be documented. Please make a PR
    in the documentation repo)
  • Readme (updated or not needed)
  • Tests (added, updated or not needed)

Copy link

Cat Gif

Copy link
Member

@webbertakken webbertakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@webbertakken webbertakken merged commit 35b5a08 into game-ci:main Mar 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants