Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore CI tests #129

Merged
merged 3 commits into from
Jan 22, 2025
Merged

Restore CI tests #129

merged 3 commits into from
Jan 22, 2025

Conversation

fingolfin
Copy link
Member

  • forms is a required package
  • recog is required for the test suite

@fingolfin fingolfin changed the title mh/tests Restore CI tests Dec 12, 2024
@fingolfin
Copy link
Member Author

Fails in tst/standard/ExtraspecialNormalizerMatrixGroups.tst:14:

# Input is:
TestExtraspecialNormalizerInSL(2, 2, 5);
# Expected output:
# But found:
Error, hash function not applicable to key of type dense plain list

Resolved in gap-packages/recog@b063fa7 -- on to the next error

@fingolfin fingolfin closed this Jan 2, 2025
@fingolfin fingolfin reopened this Jan 2, 2025
@fingolfin
Copy link
Member Author

Merged most of the changes in here into main. Several fixes were made to GAP (to appear in GAP 4.14.1) and to recog (to appear in recog 1.4.4). Still need more work

@fingolfin fingolfin force-pushed the mh/tests branch 2 times, most recently from de49152 to e1f8e1a Compare January 21, 2025 23:32
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.51%. Comparing base (0ce92bb) to head (1bcbbf4).
Report is 21 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #129   +/-   ##
=======================================
  Coverage   94.51%   94.51%           
=======================================
  Files          14       14           
  Lines        4682     4682           
=======================================
  Hits         4425     4425           
  Misses        257      257           

@fingolfin fingolfin merged commit 386c895 into main Jan 22, 2025
4 checks passed
@fingolfin fingolfin deleted the mh/tests branch January 22, 2025 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant