Skip to content

Commit

Permalink
Todos
Browse files Browse the repository at this point in the history
  • Loading branch information
ssiccha committed Mar 6, 2022
1 parent 4f0f6eb commit 23d08b2
Show file tree
Hide file tree
Showing 2 changed files with 33 additions and 0 deletions.
3 changes: 3 additions & 0 deletions gap/base/recognition.gi
Original file line number Diff line number Diff line change
Expand Up @@ -580,6 +580,8 @@ function(trivialKernel, parent)
return result;
end);

# This is for debugging purposes. TODO: I don't think we ened this anymore
# since crises are not added to the tree anymore
InstallMethod(ViewString, "for recognition crises", [IsRecogCrisis],
crisis -> "<recog crisis>");

Expand Down Expand Up @@ -907,6 +909,7 @@ function(ri, methoddb, depthString, mandarins, isSafeForMandarins)

riker := RecogNode(N,
# TODO!! safeguard this against changed method dbs
# TODO custom_decide_whether_db_is_projectiv
IsIdenticalObj(methoddb, FindHomDbProjective),
InitialDataForKernelRecogNode(ri));
SetKernelRecogNode(ri,riker);
Expand Down
30 changes: 30 additions & 0 deletions gap/obsolete.gi
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
#############################################################################
##
## This file is part of recog, a package for the GAP computer algebra system
## which provides a collection of methods for the constructive recognition
## of groups.
##
## This files's authors include Sergio Siccha.
##
## Copyright of recog belongs to its developers whose names are too numerous
## to list here. Please refer to the COPYRIGHT file for details.
##
## SPDX-License-Identifier: GPL-3.0-or-later
##
##
## Code to stay backwards-compatible.
##
#############################################################################

RECOG_DidPrintObsoleteWarningForEmptyRecognitionInfoRecord := false;
BindGlobal("EmptyRecognitionInfoRecord",
function(r, H, projective)
if not RECOG_DidPrintObsoleteWarningForEmptyRecognitionInfoRecord then
Info(InfoObsolete, 1,
"'EmptyRecognitionInfoRecord' is obsolete.",
"\n#I It may be removed in a future release of GAP.",
"\n#I Use RecogNode instead.");
RECOG_DidPrintObsoleteWarningForEmptyRecognitionInfoRecord := true;
fi;
return RecogNode(H, projective, r);
end);

0 comments on commit 23d08b2

Please sign in to comment.