Suppress dll-interface warnings (C4251) on windows

Signed-off-by: Ian Chen <[email protected]>
gazebosim · Feb 14, 2025 · b7a9a47 · b7a9a47
1 parent 3feca61
commit b7a9a47
Show file tree

Hide file tree

Showing 8 changed files with 88 additions and 0 deletions.
diff --git a/ogre2/include/gz/rendering/ogre2/Ogre2DynamicRenderable.hh b/ogre2/include/gz/rendering/ogre2/Ogre2DynamicRenderable.hh
@@ -33,6 +33,13 @@
   #pragma warning(pop)
 #endif
 
+#ifdef _MSC_VER
+  #pragma warning(push)
+  // Suppress dll-interface warning. This should no longer be needed in
+  // gz-rendering9 as visibility changed hidden by default.
+  #pragma warning(disable:4251)
+#endif
+
 namespace Ogre
 {
   class MovableObject;
@@ -154,4 +161,9 @@ namespace gz
     }
   }
 }
+
+#ifdef _MSC_VER
+  #pragma warning(pop)
+#endif
+
 #endif
diff --git a/ogre2/include/gz/rendering/ogre2/Ogre2GaussianNoisePass.hh b/ogre2/include/gz/rendering/ogre2/Ogre2GaussianNoisePass.hh
@@ -23,6 +23,13 @@
 #include "gz/rendering/ogre2/Ogre2RenderPass.hh"
 #include "gz/rendering/ogre2/Export.hh"
 
+#ifdef _MSC_VER
+  #pragma warning(push)
+  // Suppress dll-interface warning. This should no longer be needed in
+  // gz-rendering9 as visibility changed hidden by default.
+  #pragma warning(disable:4251)
+#endif
+
 namespace gz
 {
   namespace rendering
@@ -57,4 +64,9 @@ namespace gz
     }
   }
 }
+
+#ifdef _MSC_VER
+  #pragma warning(pop)
+#endif
+
 #endif
diff --git a/ogre2/include/gz/rendering/ogre2/Ogre2GlobalIlluminationCiVct.hh b/ogre2/include/gz/rendering/ogre2/Ogre2GlobalIlluminationCiVct.hh
@@ -24,6 +24,13 @@
 
 #include <memory>
 
+#ifdef _MSC_VER
+  #pragma warning(push)
+  // Suppress dll-interface warning. This should no longer be needed in
+  // gz-rendering9 as visibility changed hidden by default.
+  #pragma warning(disable:4251)
+#endif
+
 namespace Ogre
 {
   class HlmsPbs;
@@ -230,4 +237,9 @@ namespace gz
     }
   }
 }
+
+#ifdef _MSC_VER
+  #pragma warning(pop)
+#endif
+
 #endif
diff --git a/ogre2/include/gz/rendering/ogre2/Ogre2GlobalIlluminationVct.hh b/ogre2/include/gz/rendering/ogre2/Ogre2GlobalIlluminationVct.hh
@@ -24,6 +24,13 @@
 
 #include <memory>
 
+#ifdef _MSC_VER
+  #pragma warning(push)
+  // Suppress dll-interface warning. This should no longer be needed in
+  // gz-rendering9 as visibility changed hidden by default.
+  #pragma warning(disable:4251)
+#endif
+
 namespace Ogre
 {
   class HlmsPbs;
@@ -148,4 +155,9 @@ namespace gz
     }
   }
 }
+
+#ifdef _MSC_VER
+  #pragma warning(pop)
+#endif
+
 #endif
diff --git a/ogre2/include/gz/rendering/ogre2/Ogre2LensFlarePass.hh b/ogre2/include/gz/rendering/ogre2/Ogre2LensFlarePass.hh
@@ -27,6 +27,13 @@
 #include "gz/rendering/ogre2/Export.hh"
 #include "gz/rendering/ogre2/Ogre2RenderPass.hh"
 
+#ifdef _MSC_VER
+  #pragma warning(push)
+  // Suppress dll-interface warning. This should no longer be needed in
+  // gz-rendering9 as visibility changed hidden by default.
+  #pragma warning(disable:4251)
+#endif
+
 namespace gz
 {
   namespace rendering
@@ -101,4 +108,9 @@ namespace gz
     }
   }
 }
+
+#ifdef _MSC_VER
+  #pragma warning(pop)
+#endif
+
 #endif
diff --git a/ogre2/include/gz/rendering/ogre2/Ogre2Object.hh b/ogre2/include/gz/rendering/ogre2/Ogre2Object.hh
@@ -22,6 +22,13 @@
 #include "gz/rendering/ogre2/Ogre2RenderTypes.hh"
 #include "gz/rendering/ogre2/Export.hh"
 
+#ifdef _MSC_VER
+  #pragma warning(push)
+  // Suppress dll-interface warning. This should no longer be needed in
+  // gz-rendering9 as visibility changed hidden by default.
+  #pragma warning(disable:4251)
+#endif
+
 namespace gz
 {
   namespace rendering
@@ -50,4 +57,9 @@ namespace gz
     }
   }
 }
+
+#ifdef _MSC_VER
+  #pragma warning(pop)
+#endif
+
 #endif
diff --git a/ogre2/include/gz/rendering/ogre2/Ogre2RenderPass.hh b/ogre2/include/gz/rendering/ogre2/Ogre2RenderPass.hh
@@ -24,6 +24,14 @@
 #include "gz/rendering/ogre2/Export.hh"
 #include "gz/rendering/ogre2/Ogre2Object.hh"
 
+
+#ifdef _MSC_VER
+  #pragma warning(push)
+  // Suppress dll-interface warning. This should no longer be needed in
+  // gz-rendering9 as visibility changed to hidden by default.
+  #pragma warning(disable:4251)
+#endif
+
 namespace Ogre
 {
   class CompositorWorkspace;
@@ -92,4 +100,9 @@ namespace gz
     }
   }
 }
+
+#ifdef _MSC_VER
+  #pragma warning(pop)
+#endif
+
 #endif
diff --git a/ogre2/include/gz/rendering/ogre2/Ogre2RenderTargetMaterial.hh b/ogre2/include/gz/rendering/ogre2/Ogre2RenderTargetMaterial.hh
@@ -35,6 +35,9 @@
   #pragma warning(push)
   // Silence deriving from Ogre::RenderTargetListener dll-linkage warnings
   #pragma warning(disable:4275)
+  // Suppress dll-interface warning. This should no longer be needed in
+  // gz-rendering9 as visibility changed hidden by default.
+  #pragma warning(disable:4251)
 #endif
 
 namespace gz