Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: minor improvements #25

Merged
merged 2 commits into from
Oct 1, 2024
Merged

README: minor improvements #25

merged 2 commits into from
Oct 1, 2024

Conversation

scpeters
Copy link
Member

@scpeters scpeters commented Oct 1, 2024

🦟 Bug fix

Summary

This makes small improvements to the README:

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

This makes it easier to copy/paste the configuration.

Signed-off-by: Steve Peters <[email protected]>
@scpeters scpeters requested review from iche033 and jennuine October 1, 2024 17:51
@scpeters scpeters requested a review from ahcorde as a code owner October 1, 2024 17:51
Copy link
Collaborator

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you mind to sign the commit?

The base branch requires all commits to be signed. Learn more about signing commits.

@scpeters scpeters requested a review from azeey October 1, 2024 20:11
@scpeters
Copy link
Member Author

scpeters commented Oct 1, 2024

do you mind to sign the commit?

The base branch requires all commits to be signed. Learn more about signing commits.

so not a DCO signature but a GPG signature?

@scpeters
Copy link
Member Author

scpeters commented Oct 1, 2024

do you mind to sign the commit?

The base branch requires all commits to be signed. Learn more about signing commits.

so not a DCO signature but a GPG signature?

I don't think this is required on any other gazebo repositories so I don't have it enabled. I'll read the documentation to figure out how to set it up

@ahcorde ahcorde merged commit 6548a11 into main Oct 1, 2024
5 checks passed
@ahcorde ahcorde deleted the scpeters/readme branch October 1, 2024 20:25
@ahcorde
Copy link
Collaborator

ahcorde commented Oct 1, 2024

https://github.com/Mergifyio backport fortress garden

Copy link

mergify bot commented Oct 1, 2024

backport fortress garden

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Oct 1, 2024
Signed-off-by: Steve Peters <[email protected]>
(cherry picked from commit 6548a11)

# Conflicts:
#	README.md
@mergify mergify bot mentioned this pull request Oct 1, 2024
8 tasks
mergify bot pushed a commit that referenced this pull request Oct 1, 2024
Signed-off-by: Steve Peters <[email protected]>
(cherry picked from commit 6548a11)

# Conflicts:
#	README.md
@mergify mergify bot mentioned this pull request Oct 1, 2024
8 tasks
ahcorde pushed a commit that referenced this pull request Oct 1, 2024
* README: minor improvements (#25)

Signed-off-by: Steve Peters <[email protected]>
(cherry picked from commit 6548a11)
ahcorde pushed a commit that referenced this pull request Oct 2, 2024
* README: minor improvements (#25)

Signed-off-by: Steve Peters <[email protected]>
(cherry picked from commit 6548a11)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants