Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for cone shapes #26

Merged
merged 2 commits into from
Oct 2, 2024
Merged

Add support for cone shapes #26

merged 2 commits into from
Oct 2, 2024

Conversation

scpeters
Copy link
Member

@scpeters scpeters commented Oct 1, 2024

🎉 New feature

Summary

Cone shapes were added to Ionic and backported to Harmonic in sdformat 14.4. This adds support for converting cone shapes between SDFormat and USD.

Test it

Attempting to convert the gz-sim shapes.sdf example world on main causes the conversion to fail with error messages like the following:

Error Code 2: Msg: Error parsing link [cone_link]
Error Code 7: Msg: Geometry type is either invalid or not supported

It works properly with this branch.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@scpeters
sdf_parser: support Cone shape
e9131bd 
Requires sdformat 14.4 on harmonic.

Signed-off-by: Steve Peters <[email protected]>
@scpeters
usd_parser: support cone shape
0907d62 
Signed-off-by: Steve Peters <[email protected]>
@scpeters scpeters requested review from azeey, iche033 and jennuine October 1, 2024 20:10
@scpeters scpeters requested a review from ahcorde as a code owner October 1, 2024 20:10
@ahcorde ahcorde merged commit 330f1c9 into main Oct 2, 2024
5 checks passed
@ahcorde
Copy link
Collaborator

ahcorde commented Oct 2, 2024

https://github.com/Mergifyio backport fortress garden

@ahcorde ahcorde deleted the scpeters/cone branch October 2, 2024 08:19
@mergify Mergify
Copy link

mergify bot commented Oct 2, 2024 •
edited
Loading

backport fortress garden

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Oct 2, 2024
@scpeters @mergify
Add support for cone shapes (#26)
eaf37e1 
Signed-off-by: Steve Peters <[email protected]>
(cherry picked from commit 330f1c9)

# Conflicts:
#	CMakeLists.txt
mergify bot pushed a commit that referenced this pull request Oct 2, 2024
@scpeters @mergify
Add support for cone shapes (#26)
fada4d0 
Signed-off-by: Steve Peters <[email protected]>
(cherry picked from commit 330f1c9)

# Conflicts:
#	CMakeLists.txt
This was referenced Oct 2, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde approved these changes

@azeey azeey Awaiting requested review from azeey

@iche033 iche033 Awaiting requested review from iche033

@jennuine jennuine Awaiting requested review from jennuine

Assignees
No one assigned
Labels
None yet
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scpeters @ahcorde