Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set view as empty with double tap #91

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+5 −2
Open

Set view as empty with double tap #91

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ec3840
Set view as empty with double tap
Mauker1 Jul 25, 2017
8d600b6
Update SignaturePad.java
Mauker1 Sep 26, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions signature-pad/src/main/java/com/github/gcacace/signaturepad/views/SignaturePad.java
View file
Original file line number Diff line number Diff line change
@@ -208,7 +208,11 @@ public boolean onTouchEvent(MotionEvent event) {
case MotionEvent.ACTION_DOWN:
getParent().requestDisallowInterceptTouchEvent(true);
mPoints.clear();
if (isDoubleClick()) break;
if (isDoubleClick()) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you extract from the function isDoubleClick() the part where the signature is cleared, so we can have the clearing part and the setIsEmpty(true) in the same place? I'd like to have isDoubleClick() as immutable method.

Copy link
Author

@Mauker1 Mauker1 Sep 26, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. Can you take a look at the new commit to check if that's what you wanted?

this.clearView();
setIsEmpty(true);
break;
}
mLastTouchX = eventX;
mLastTouchY = eventY;
addPoint(getNewPoint(eventX, eventY));
@@ -411,7 +415,6 @@ private boolean isDoubleClick() {
} else if (mCountClick == 2) {
long lastClick = System.currentTimeMillis();
if (lastClick - mFirstClick < DOUBLE_CLICK_DELAY_MS) {
this.clearView();
return true;
}
}