Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

android: fixed errors reported in the lint test #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

drzraf
Copy link
Contributor

@drzraf drzraf commented Nov 19, 2015

  • showAsAction namespace
  • minSdkVersion == 14 since parent="android:Theme.Holo.Light.DarkActionBar"
    (src/main/res/values/styles.xml) is not available before

and a couple of lint warnings:

  • SetJavaScriptEnabled is legitimate
  • before in app/src/main/AndroidManifest.xml

- showAsAction namespace
- minSdkVersion == 14 since parent="android:Theme.Holo.Light.DarkActionBar"
  (src/main/res/values/styles.xml) is not available before

and a couple of lint warnings:
- SetJavaScriptEnabled is legitimate
- <uses-permission> before <application> in app/src/main/AndroidManifest.xml
@gdesmott
Copy link
Owner

@rberiot : can you review this please?

@rberiot
Copy link
Collaborator

rberiot commented Nov 19, 2015

@drzraf is there a reason in our case to use
parent="android:Theme.Holo.Light.DarkActionBar"
as we are currently just wrapping a fullscreen webview?
bumping the API level from 10 to 14 means we only android 4.0+ instead of 2.3.3+

@drzraf
Copy link
Contributor Author

drzraf commented Nov 19, 2015 via email

@gdesmott
Copy link
Owner

Yeah ideally it would be bettter to use an older theme so we don't have to bump the dep.

@drzraf
Copy link
Contributor Author

drzraf commented Dec 21, 2015

just a ping about this one, since it's old, is an easy one and is a preliminary step before thinking into having a vegoresto-app (or extending manger-veggie's app)

@gdesmott
Copy link
Owner

The maintainer of the Android app, @rberiot, on holidays atm so he won't have be able to look at it for now.

Any chance you could take a look and check if using an older theme would fix the warning as well?

@drzraf
Copy link
Contributor Author

drzraf commented Jan 20, 2016

I'm pretty sure that yes (cf lint log), but I'm not knowledgeable enough to make and test the change.
ping @rberiot again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants