Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve efficiency of ORM lookup in dashboard #474

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

code-review-doctor
Copy link

@code-review-doctor code-review-doctor commented Feb 2, 2021

I found this issue automatically using https://django.doctor/geex-arts/django-jet

@code-review-doctor code-review-doctor changed the title Fix some django anti-patterns Improve efficiency of ORM lookup in dashboard Feb 2, 2021
@@ -137,7 +137,7 @@ def load_modules(self):
user=self.context['request'].user.pk
).all()

if len(module_models) == 0:
if not module_models.exists():
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@coveralls
Copy link

coveralls commented Feb 2, 2021

Coverage Status

Coverage remained the same at 52.381% when pulling 797da5b on django-doctor:django-doctor-fix-1612252107397.8674 into 06ab643 on geex-arts:dev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants