chore: use github ci #640
Open
chore: use github ci #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KuznetsovRoman
force-pushed
the
TRIVIAL.use_gh_ci
branch
27 times, most recently
from
b7d25f8 to
7400473
Compare
✅ Testplane run succeed |
KuznetsovRoman
force-pushed
the
TRIVIAL.use_gh_ci
branch
from
7400473 to
969cec5
Compare
KuznetsovRoman
force-pushed
the
TRIVIAL.use_gh_ci
branch
26 times, most recently
from
7efeb5c to
aec1134
Compare
KuznetsovRoman
force-pushed
the
TRIVIAL.use_gh_ci
branch
from
aec1134 to
8f14a0a
Compare
KuznetsovRoman
commented
Mar 20, 2025
| destination_dir: ${{ env.DEST_REPORTS_DIR }} | ||
| keep_files: true | ||
|
|
||
| - name: Construct failed PR comment |
There was a problem hiding this comment.
Couldn't figure out smarter way to do this.
I tried constructing variables like STEP_TESTPLANE_TESTPLANE_COMMON_OUTCOME and evaluating them, but it does not work
| @@ -38,7 +38,7 @@ test.describe('failed describe', () => { | |||
| test('test with successful assertView and error', async ({page, baseURL}) => { | |||
| await page.goto(baseURL as string); | |||
|
|
|||
| await expect(page.locator('header')).toHaveScreenshot('header-success.png'); | |||
| await expect(page.locator('header')).toHaveScreenshot('header-success.png', {maxDiffPixelRatio: 1}); | |||
There was a problem hiding this comment.
As its "test with successful assertView" (fixture), we can make this test 100% stable
| @@ -8,6 +8,6 @@ describe('success describe', function() { | |||
| it('test with screenshot', async ({browser}) => { | |||
| await browser.url(browser.options.baseUrl); | |||
|
|
|||
| await browser.assertView('header', 'header'); | |||
| await browser.assertView('header', 'header', {ignoreDiffPixelCount: '100%'}); | |||
There was a problem hiding this comment.
As its "success-describe" (fixture), we can make this test 100% stable
There was a problem hiding this comment.
Copied from "testplane-gui"
Comment on lines
+29
to
+34
| }).on('error', err => { | ||
| if (err.code === 'EADDRINUSE') { | ||
| console.warn(`Skip running server, because port ${port} is busy`); | ||
| } else { | ||
| throw err; | ||
| } |
There was a problem hiding this comment.
- We run Testplane (which uses this html-reporter-test-server and opens the server on SERVER_PORT)
- Testplane runs Testplane GUI (port GUI_PORT)
- Testplane GUI uses html-reporter-test-server and tries to run server on SERVER_PORT
- Testplane runs Testplane GUI (port GUI_PORT)
| getTestStateByNameSelector('header') + | ||
| getElementWithTextSelector('span', field) + '/..' | ||
| ); | ||
| const errorMessage = await parentElement.$(getElementWithTextSelector('span', field) + '/..'); |
There was a problem hiding this comment.
For some reason, it didn't work that way (though only for "name")
| @@ -15,7 +15,7 @@ describe('Test redux plugin', function() { | |||
| await browser.$(screenSelector).waitForDisplayed(); | |||
| await browser.$(clickSelector).click(); | |||
| // Letting browser handle re-renders | |||
| await browser.pause(300); | |||
| await browser.pause(1000); | |||
There was a problem hiding this comment.
500 wasn't enough either
KuznetsovRoman
commented
Mar 20, 2025
Comment on lines
+202
to
+205
| - name: Leave failed comment to PR with link to Testplane HTML reports | ||
| if: env.IS_FAILED | ||
| id: leave-failed-comment-step | ||
| uses: thollander/actions-comment-pull-request@v3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.