[GraphHopper] Add provider parameter #1251
Conversation
There was a problem hiding this comment.
This is a feature still in development.
The provider parameter is currently under development and can fall back to default at any time.
-- https://docs.graphhopper.com/openapi/geocoding/getgeocode#geocoding/getgeocode/t=request&in=query&path=provider
| $provider = $query->getData('provider'); | ||
| if (is_string($provider) && '' !== $provider) { | ||
| $url .= sprintf('&provider=%s', urlencode($provider)); | ||
| } |
There was a problem hiding this comment.
Maybe worth creating an enum with the list of available providers?
There was a problem hiding this comment.
Does all providers return the necessary result?
There was a problem hiding this comment.
Enum would be no problem, but when the list expands another PR has to be made.
What do you mean by 'Does all providers return the necessary result?'. We do need one specific provider that works best for our case
There was a problem hiding this comment.
What do you mean by 'Does all providers return the necessary result?'. We do need one specific provider that works best for our case
Is the response from GraphHopper different if we select a provider other than 'default'? Just to know if we need to implement specific logic if we choose another provider than the default one.
There was a problem hiding this comment.
I tested a little and the response seems to be quiety different depending on the address searched. Latitude and longitude are always present. But there are parameters , which are set depending on provider but as well the search string. So I'm not sure if its really useful to add them. However, the main address attributes such as city, country, street or postcode seem to be the same for all providers.
One question: I was already wondering why the classes are made final if not so a user could extend e.g. the GraphHopper provider and Address Model to add properties if needed.
There was a problem hiding this comment.
As the enum feature is supported since php 8.1 but code has to be valid for php 8.0 as well, I will remove it again. Do you have another suggestion?
Graphhopper geocoding supports different providers. Hereby the option is given to use those providers.
bisleadity
force-pushed
the
feature/graphhopper-add-provider
branch
from
8fedd22 to
4d66689
Compare
…aphHopper geocoding api Graphhopper geocoding supports different providers. Hereby the option is given to use only available providers. [GraphHopper] Add GraphHopperProviders enum for provider options of GraphHopper geocoding api Graphhopper geocoding supports different providers. Hereby the option is given to use only available providers.
bisleadity
force-pushed
the
feature/graphhopper-add-provider
branch
from
0fbc0e1 to
320b5d7
Compare
…ns of GraphHopper geocoding api" This reverts commit 320b5d7.
Graphhopper geocoding now supports different providers. Hereby the option is given to use those providers.
As we do need to use one of those providers and there was no possibility given so far I added it.