Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datahubs per sub-portal #8644

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Guillaume-d-o
Copy link

@Guillaume-d-o Guillaume-d-o commented Feb 6, 2025

This is the continuation of the proof-of-concept for the proposal #8021

This work aim to create and manage a datahub in a plugin. The Datahub application, once compiled, is a collection of static files (HTML, JS, CSS) that can be served as is. If you want more information, I strongly encourage you to read the proposal #8021 that explain all the developement in details.
We tried to maximise all the code on the plugin side.

Checklist

  • I have read the contribution guidelines
  • Pull request provided for main branch, backports managed with label
  • Good housekeeping of code, cleaning up comments, tests, and documentation
  • Clean commit history broken into understandable chucks, avoiding big commits with hundreds of files, cautious of reformatting and whitespace changes
  • Clean commit messages, longer verbose messages are encouraged
  • API Changes are identified in commit messages
  • Testing provided for features or enhancements using automatic tests
  • User documentation provided for new features or enhancements in manual
  • Build documentation provided for development instructions in README.md files
  • Library management using pom.xml dependency management. Update build documentation with intended library use and library tutorials or documentation

@CLAassistant
Copy link

CLAassistant commented Feb 6, 2025

CLA assistant check
All committers have signed the CLA.

@Guillaume-d-o Guillaume-d-o force-pushed the GSIRD-3-temp branch 3 times, most recently from 2fbf024 to 30d9db8 Compare February 17, 2025 15:50
@Guillaume-d-o Guillaume-d-o changed the title Gsird 3 temp datahubs per sub-portal Feb 17, 2025
@Guillaume-d-o Guillaume-d-o marked this pull request as ready for review February 18, 2025 13:43
@Guillaume-d-o Guillaume-d-o marked this pull request as draft February 18, 2025 13:46
@fgravin fgravin requested a review from josegar74 February 18, 2025 14:12
@fgravin
Copy link
Member

fgravin commented Feb 18, 2025

Awesome !! 🤩
Thanks @Guillaume-d-o

@Guillaume-d-o Guillaume-d-o marked this pull request as ready for review February 18, 2025 14:20
@fgravin
Copy link
Member

fgravin commented Feb 21, 2025

@Guillaume-d-o could you check the CI please, seems there is an issue during the build.

Copy link
Contributor

@jahow jahow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Haven't tested yet but I've seen it work. We should address my comments first and then I'll do another final review.

Comment on lines +10 to +11
INSERT INTO Settings (name, value, datatype, position, internal) VALUES ('geonetwork-ui/datahub/enabled', 'false', 2, 7404, 'n');
INSERT INTO Settings (name, value, datatype, position, internal) VALUES ('geonetwork-ui/datahub/configuration', '
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following the feedback in #8021 (comment) you should be able to avoid using the Settings table and use the same table (Sources) for all configurations, including the default one.

@@ -635,6 +635,13 @@
<version>${xmlunit.version}</version>
<scope>test</scope>
</dependency>
<!-- FIXME: only add this with the datahub-integration profile -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this be fixed?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

completely forgot this line sorry :(

Comment on lines +276 to +279
## Geonetwork-ui configuration

*Enable datahub*:
You can adapt your GeoNetwork UI by enabling Datahub. First, download the specific plugin datahub-integration. Then, on the settings page, enable Datahub . you can provide an other specific Datahub configuration than the default one. You can also configure it for each portal. Ensure that Datahub is enabled in the settings to make it work on portals.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for documenting your work. IMO this should go in a separate section of the documentation. The things that need to be documented are:

  • what the plugin does (with a link to GeoNetwork-UI project)
  • how to build the plugin
  • how to enable it
  • how to configure the datahub instances (link to the relevant documentation in GN-UI)

We might start a new "plugins" section in the documentation for that, I think that'd be appropriate. @jodygarnett do you have any opinion on how/where to put this? thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants