-
-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
datahubs per sub-portal #8644
base: main
Are you sure you want to change the base?
datahubs per sub-portal #8644
Conversation
2fbf024
to
30d9db8
Compare
Awesome !! 🤩 |
4b09816
to
a351411
Compare
a351411
to
dd54831
Compare
@Guillaume-d-o could you check the CI please, seems there is an issue during the build. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Haven't tested yet but I've seen it work. We should address my comments first and then I'll do another final review.
INSERT INTO Settings (name, value, datatype, position, internal) VALUES ('geonetwork-ui/datahub/enabled', 'false', 2, 7404, 'n'); | ||
INSERT INTO Settings (name, value, datatype, position, internal) VALUES ('geonetwork-ui/datahub/configuration', ' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following the feedback in #8021 (comment) you should be able to avoid using the Settings table and use the same table (Sources) for all configurations, including the default one.
@@ -635,6 +635,13 @@ | |||
<version>${xmlunit.version}</version> | |||
<scope>test</scope> | |||
</dependency> | |||
<!-- FIXME: only add this with the datahub-integration profile --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't this be fixed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
completely forgot this line sorry :(
## Geonetwork-ui configuration | ||
|
||
*Enable datahub*: | ||
You can adapt your GeoNetwork UI by enabling Datahub. First, download the specific plugin datahub-integration. Then, on the settings page, enable Datahub . you can provide an other specific Datahub configuration than the default one. You can also configure it for each portal. Ensure that Datahub is enabled in the settings to make it work on portals. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for documenting your work. IMO this should go in a separate section of the documentation. The things that need to be documented are:
- what the plugin does (with a link to GeoNetwork-UI project)
- how to build the plugin
- how to enable it
- how to configure the datahub instances (link to the relevant documentation in GN-UI)
We might start a new "plugins" section in the documentation for that, I think that'd be appropriate. @jodygarnett do you have any opinion on how/where to put this? thanks!
This is the continuation of the proof-of-concept for the proposal #8021
This work aim to create and manage a datahub in a plugin. The Datahub application, once compiled, is a collection of static files (HTML, JS, CSS) that can be served as is. If you want more information, I strongly encourage you to read the proposal #8021 that explain all the developement in details.
We tried to maximise all the code on the plugin side.
Checklist
main
branch, backports managed with labelREADME.md
filespom.xml
dependency management. Update build documentation with intended library use and library tutorials or documentation