Fix version of json-smart library to avoid build issue: #8654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ERROR] Failed to execute goal on project gn-core: Could not resolve dependencies for project org.geonetwork-opensource:gn-core:jar:4.4.7-SNAPSHOT: Failed to collect dependencies at org.springframework.security:spring-security-oauth2-client:jar:5.8.15 -> com.nimbusds:oauth2-oidc-sdk:jar:9.43.3 -> net.minidev:json-smart:jar:[1.3.3,2.4.10]: No versions available for net.minidev:json-smart:jar:[1.3.3,2.4.10] within specified range -> [Help 1]
|
|
Can confirm this works on the VL fork. Thank you for the fix! |
|
Today the build works again without requiring this change. I'll keep the pull request as draft in case it could happen in the future again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build started failing in
mainand4.2.xbranches:It's unclear the reason why this is happening now, but seems there are some old reports about this issue:
https://bitbucket.org/connect2id/oauth-2.0-sdk-with-openid-connect-extensions/issues/370/variable-range-of-netminidev-json-smart
New versions of nimbus
com.nimbusds:oauth2-oidc-sdk(since 10.14.1) uses a fixed version ofjson-smartinstead of defining a range, fixing the problem. But the spring security version used in GeoNetwork uses an older dependency of nimbuscom.nimbusds:oauth2-oidc-sdkthat uses a range of versions forjson-smart.Checklist
mainbranch, backports managed with labelREADME.mdfilespom.xmldependency management. Update build documentation with intended library use and library tutorials or documentation