Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Webcomponents] : Full text search #1122

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

cmoinier
Copy link
Collaborator

@cmoinier cmoinier commented Feb 18, 2025

Description

This PR makes numerous fixes on the gn-search-input webcomponent.

  • Placeholder is now an Input to avoid having an empty value
  • White background for dropdown
  • Fixed space between input and dropdown
  • Fixed results-list implementation in gn-search-input-and-results
  • Ported various fixes from geocat
  • Added cache cleaning in build script because changes are not always taken into account
  • Added e2e component testing

Architectural changes

none

Quality Assurance Checklist

  • Commit history is devoid of any merge commits and readable to facilitate reviews
  • If new logic ⚙️ is introduced: unit tests were added
  • If new user stories 🤏 are introduced: E2E tests were added
  • If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
  • If breaking changes 🪚 are introduced: add the breaking change label
  • If bugs 🐞 are fixed: add the backport <release branch> label
  • The documentation website 📚 has received the love it deserves

Copy link
Contributor

github-actions bot commented Feb 18, 2025

Affected libs: api-repository,
Affected apps: webcomponents,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

Copy link
Contributor

github-actions bot commented Feb 18, 2025

📷 Screenshots are here!

@cmoinier cmoinier force-pushed the wc-full-text-search branch from 91cced1 to 6525bb0 Compare February 21, 2025 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants