-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #10783 Support for favorites #10795
Fix #10783 Support for favorites #10795
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, also the code is good.
My only comment is about accessibility of "Favs" that is a little hidden and not so immediate, as a filter.
As a user, I expect to have a quick button to reach my favorites (anyway the same is for my own resources)
Take it as a suggestion for a futher improvemnt. Some ideas are:
@offtherailz included your comment here #10774 |
@ElenaGallo please test this new feature on dev, thanks |
Description
This PR introduces:
Card with the favorites button
favorites.mp4
New checkbox in the filter form
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
#10783
What is the new behavior?
A new favorites button has been added to the resource cards
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information
This PR must be merged after the implementation on GeoStore has been completed (see geosolutions-it/geostore#402)