Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#10737: Interactive legend for TOC layers [Vector Layer part] #10798

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mahmoudadel54
Copy link
Contributor

Description

This PR handled adding the interactivity to the Vector Legend for the vector layer in cesium, openalayers and leaflet. It includes:

  • handle adding checkbox in layer settings in TOC for enabling/disabling interactive legend for vector layer
  • handle the same behaviour in WFS/WMS of hovering effect on the legend items if classified on TOC and select effect

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Issue

#10737

What is the current behavior?
#10737

What is the new behavior?
Now user can interact with the vector legend for vector layers if it is enabled by user from TOC.

recording.14.mp4

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

  • To test it, you should add "miscSettings": { "experimentalInteractiveLegend": true}, to localConfig

  • To test functionality for leaflet maps, you should change this:

    desktop: MapLibraries.OPENLAYERS

to desktop: MapLibraries.LEAFLET

…r part]

Description:
- handle adding checkbox in layer settings in TOC for enabling/disabling interactive legend for vector layer
- handle the same behaviour in WFS/WMS of hovering effect on the legend items if classified on TOC and select effect
- Add interactivity to the Vector Legend for the vector layer in cesium, openalayers and leaflet
- add unit tests
@mahmoudadel54 mahmoudadel54 added the New Feature used for new functionalities label Feb 4, 2025
@mahmoudadel54 mahmoudadel54 added this to the 2025.01.00 milestone Feb 4, 2025
@mahmoudadel54 mahmoudadel54 self-assigned this Feb 4, 2025
@mahmoudadel54 mahmoudadel54 linked an issue Feb 4, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Feature used for new functionalities
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interactive legend for TOC layers [Vector Layer part]
1 participant