Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minitest tagz 20240130 #351

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Minitest tagz 20240130 #351

merged 1 commit into from
Feb 5, 2024

Conversation

apotterri
Copy link
Contributor

Check to see if Minitest::Tagz has been used the add the tag :noappmap
to a test method. If so, don't generate an AppMap for the test.

Fixes #350 .

@apotterri apotterri force-pushed the minitest-tagz_20240130 branch 2 times, most recently from f5554e2 to 6cf16f0 Compare February 4, 2024 10:10
@apotterri apotterri marked this pull request as ready for review February 4, 2024 10:29
Check to see if Minitest::Tagz has been used to add the tag :noappmap to
a test method. If so, don't generate an AppMap for the test.

BREAKING CHANGE: bump to version 1.0.0
@apotterri
Copy link
Contributor Author

Kind of unfortunate that semantic-release requires the ominous-sounding "BREAKING CHANGE" in the comment to bump to v1.0.0....

@kgilpin
Copy link
Contributor

kgilpin commented Feb 4, 2024

Yes that’s why we are still on v0 :-)

@apotterri
Copy link
Contributor Author

I still think we should do it (and probably should have done it a while ago). It's quite stable, and just continuing to increment the minor version seems weird....

@kgilpin
Copy link
Contributor

kgilpin commented Feb 4, 2024

Yeah me too.

@apotterri apotterri added the enhancement New feature or request label Feb 5, 2024
@apotterri apotterri merged commit 93198b5 into master Feb 5, 2024
1 check passed
@apotterri apotterri deleted the minitest-tagz_20240130 branch February 5, 2024 20:20
@kgilpin
Copy link
Contributor

kgilpin commented Feb 6, 2024

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minitest recording can be selectively disabled using tags
2 participants