-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for 'linux/arm64' platforms #7094
Conversation
This month's snapshot has already been created, so once this PR is approved and merged, |
This PR is a lot simpler than I was expecting for adding ARM64 support. I kind of imagined it'd be some super complicated thing, so I'm glad it didn't need to be. 😄 |
I created a PR that adds options to make it easier to create new snapshots: #7096 |
after adding
😿 😿 😿 |
What's a "gha"? 😄 |
github actions 😛
|
now i'm 90% sure that |
My gut tells me |
@justinclift my gut feeling was wrong, the culprit is poetry version mis-match #7122 |
Co-authored-by: Justin Clift <[email protected]>
What type of PR is this?
Description
When we take a snapshot, it also creates a Docker image for the ARM64 platform.
How is this tested?
setup
script on Ubuntu 24.04 installed on ARM64-based processorRelated Tickets & Documents
#5765
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
Not applicable.
Notes
Currently, it takes about 3h to build a docker image.
Of course, I have a new ways in mind to improve this speed(cache, matrix, etc.). But PRs can get too complicated,
so I'm going to make changes to the core functionality first, and then improve the speed with additional PRs.
Any comments or review are welcome. Thank you.