Skip to content
This repository has been archived by the owner on May 6, 2024. It is now read-only.

feat: Add configuration file for Sentry dev #25

Closed
wants to merge 2 commits into from

Conversation

lynnagara
Copy link
Member

Use this configuration if running CDC in a Sentry dev environment

Use this configuration if running CDC in a Sentry dev environment
Copy link
Contributor

@fpacifici fpacifici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this would fit better in the sentry codebase where we store the config for relay, symbolicator and others.
https://github.com/getsentry/sentry/tree/master/config

When we will start up cdc (or allow cdc) in sentry development environment, it will be start up by sentry, most likely as a devservices and they are all configured with sentry providing the config file.


sentry:
enabled: false # unless you want to enable sentry locally, then change the DSN below
dsn: 'http://[email protected]:8000/PROJECT'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing new line

source:
type: postgres
options:
dsn: 'postgres://postgres@localhost:5432/pgbench'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this would have to be changed as well.

options:
topic: cdc_control
options:
bootstrap.servers: 'localhost:9092'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sentry_kafka:9092

bootstrap.servers: 'sentry_kafka:9093'

dogstatsd:
host: host.docker.internal # I think, or wherever you have statsd if you have it
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add a flag to disable this. Most sentry users do not have it in the dev environment.

@lynnagara
Copy link
Member Author

I think this would fit better in the sentry codebase where we store the config for relay, symbolicator and others.
https://github.com/getsentry/sentry/tree/master/config

When we will start up cdc (or allow cdc) in sentry development environment, it will be start up by sentry, most likely as a devservices and they are all configured with sentry providing the config file.

That makes sense when CDC moves into devservices and becomes a Sentry dependency. In the meantime, this still needs to live somewhere.

Copy link
Contributor

@fpacifici fpacifici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can just add the file there right away (and reference that file from wherever you run cdc). Anyway not a big deal for as long as this is temporary.

Mind adding a comment in the file that says we are moving this to sentry ?

@getsantry
Copy link

getsantry bot commented Oct 18, 2023

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Oct 18, 2023
@asottile-sentry
Copy link
Member

closing: archiving repo

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants