feat(docker): Adds a cloudbuild file to publish the docker image

[fpacifici]

This adds a new cloudbuild file to create the docker image and publish it on the public repo.

Specifically:

• It does not remove the old cloudbuild so we can merge the new one for the public repo, have the first image published and, once that is verified to work properly remove the old one. During this process it is desirable to preserve the old file in a functioning state to be able to apply a fix and do a deployment if needed.
• It adds a docker compose file to let cloudbuild run the unit tests before publishing the image.

[BYK]

I have two concerns:

1. I don't understand why we don extend the existing cloudbuild.yaml file instead of introducing a new one (and adding new triggers).
2. I don't think the testing we do here is efficient or useful as we should be running unit tests on GitHub Actions anyway, right?

[fpacifici]

Thanks, will address the comment soon

I don't understand why we don extend the existing cloudbuild.yaml file instead of introducing a new one (and adding new triggers).

To my knowledge if I extend the existing one and then call it from two triggers (one is the one we use today to generate the internal image (this repo was used to be private) and the other would be a new one on the public repo), The private one would try to publish the image on the public repo. I don't think that would work.

[BYK]

To my knowledge if I extend the existing one and then call it from two triggers (one is the one we use today to generate the internal image (this repo was used to be private) and the other would be a new one on the public repo), The private one would try to publish the image on the public repo. I don't think that would work.

Not sure if I fully grasp what you have in mind here so will do a Slack sync before doing another pass on this PR. Thanks a lot for all the updates and providing additional context!

[fpacifici]

I tested the cloudbuild file and plugged it whenever a PR is updated and a commit on master happens.
It now works: https://console.cloud.google.com/cloud-build/builds/d361cbdf-9bf1-4c6c-9eb5-789d3126ab54?project=sentryio

Also removed the build step of the cdc image from the e2e test. Now it uses the same image we are going to push to the registry even to execute the test script.

[BYK]

I guess this is obsolete now as we use the same image for testing and just install pytest at container start?

[fpacifici]

Actually no, this is still needed for the CI github actions

[BYK]

I'd really like to remove the multi-stage Docker file, at least for testing image.

[fpacifici]

Ok, I can split it into two files. What's the reasoning for preferring two files too a multi stage Dockerfile? I thought multi stage was meant for use cases like this.