This repository has been archived by the owner on May 6, 2024. It is now read-only.
fix(ci) Fix the registry url for cloudbuild #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fpacifici
force-pushed
the
fix/cloudbuild
branch
3 times, most recently
from
c20cf5e to
5ef16a9
Compare
fpacifici
force-pushed
the
fix/cloudbuild
branch
from
5ef16a9 to
f720f2e
Compare
BYK
suggested changes
Apr 19, 2021
cloudbuild_public.yaml
Outdated
| @@ -42,20 +42,24 @@ steps: | |||
| - | | |||
| # Only push to Docker Hub from master | |||
| [ "$BRANCH_NAME" != "master" ] && exit 0 | |||
| docker pull us.gcr.io/$PROJECT_ID/$REPO_NAME:$COMMIT_SHA | |||
| docker pull $$SENTRY_IMAGE | |||
There was a problem hiding this comment.
Please make this $$CDC_IMAGE as SENTRY_IMAGE has a special meaning in on-premise and it will interfere.
|
Also looks like we need a |
That was an issue. But I think also creating the |
|
@BYK thanks for adding the repo on docker. Now it works. |
BYK
approved these changes
Apr 20, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current cloudbuild cannot push the docker image because the url is wrong.
Anyway this fails as well for the lack of permissions, but it is more right than before.