Skip to content
This repository has been archived by the owner on May 6, 2024. It is now read-only.

feat(releasing): Add release script to CDC #36

Merged
merged 3 commits into from
Jun 11, 2021
Merged

Conversation

fpacifici
Copy link
Contributor

@fpacifici fpacifici commented May 7, 2021

We will have to cut releases.

This now does not follow calver, but that is up for debate. CDC is not a core part of sentry, more of an external dependency (it is also not BSL @BYK what do you think? ).

@fpacifici fpacifici changed the title Release CDC feat(releasing) Add release script to CDC May 7, 2021
@fpacifici fpacifici requested review from a team May 7, 2021 00:21
@fpacifici fpacifici marked this pull request as ready for review May 7, 2021 00:21
@BYK BYK changed the title feat(releasing) Add release script to CDC feat(releasing): Add release script to CDC May 7, 2021
Copy link
Member

@BYK BYK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will have to cut releases.

Can you elaborate on why?

This now does not follow calver, but that is up for debate. CDC is not a core part of sentry, more of an external dependency (it is also not BSL @BYK what do you think? ).

If this is a project like Snuba, specific to Sentry and needs to go in lock-step, it should use CalVer and BSL. If it is a project that can be used outside of Sentry, like Symbolicator, then we should use Apache-2 and SemVer.

@fpacifici
Copy link
Contributor Author

Can you elaborate on why?

I thought that would be the cleanest way to pin a release when we cut an on premise release. We could reference a specific commit otherwise.

If this is a project like Snuba, specific to Sentry and needs to go in lock-step, it should use CalVer and BSL. If it is a project that can be used outside of Sentry, like Symbolicator, then we should use Apache-2 and SemVer.

So semver. Thanks.

@BYK
Copy link
Member

BYK commented May 7, 2021

We could reference a specific commit otherwise.

The approach we have taken with Symbolicator is to take the latest published release instead of latest master commit SHA.

@fpacifici
Copy link
Contributor Author

The approach we have taken with Symbolicator is to take the latest published release instead of latest master commit SHA.

Right, so we do have to cut and publish releases for that, or am I missing something?

@BYK
Copy link
Member

BYK commented May 7, 2021

Right, so we do have to cut and publish releases for that, or am I missing something?

Yes we do.

@fpacifici fpacifici merged commit 2e0420b into master Jun 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants