This repository has been archived by the owner on May 6, 2024. It is now read-only.
build cdc for multiarch #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asottile-sentry
force-pushed
the
asottile-multiarch
branch
7 times, most recently
from
289f07d to
5f3d8ce
Compare
asottile-sentry
force-pushed
the
asottile-multiarch
branch
from
5f3d8ce to
caf3b5c
Compare
joshuarli
reviewed
Aug 29, 2022
| @@ -3,5 +3,5 @@ PyYAML==5.1 | |||
| confluent-kafka==0.11.6 | |||
| datadog==0.21.0 | |||
| jsonschema==3.0.1 | |||
| psycopg2-binary==2.7.7 | |||
| psycopg2-binary==2.9.3 | |||
There was a problem hiding this comment.
yeah the older version does not build on arm64
joshuarli
approved these changes
Aug 29, 2022
fpacifici
approved these changes
Aug 30, 2022
There was a problem hiding this comment.
Are you trying to make our fork of wal2json multi arch as well ?
https://github.com/getsentry/wal2json
| @@ -58,7 +58,13 @@ RUN mkdir -p /usr/src/app | |||
| WORKDIR /usr/src/app | |||
|
|
|||
| COPY requirements.txt /usr/src/app/ | |||
| RUN pip install -r requirements.txt | |||
| RUN set -x \ | |||
| && deps='gcc librdkafka-dev libc-dev' \ | |||
There was a problem hiding this comment.
confluent-kafka doesn't have a prebuilt on arm64 sadly
hmmm! wasn't aware of this but if I run into it I'll fix it too ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this will push an app image to ghcr, built for both amd64 and arm64 for use with the sentry dev tools