Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracing without performance out of the box and deprecated Span.set_data() #4223

Draft
wants to merge 8 commits into
base: potel-base
Choose a base branch
from

Conversation

antonpirker
Copy link
Member

Second part of #4102

@antonpirker antonpirker requested a review from a team as a code owner April 1, 2025 10:54
Copy link

codecov bot commented Apr 1, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
20691 1 20690 4422
View the top 1 failed test(s) by shortest run time
tests.integrations.grpc.test_grpc_aio test_grpc_server_abort
Stack Traces | 0.101s run time
.../integrations/grpc/test_grpc_aio.py:153: in test_grpc_server_abort
    assert len(events) == 1
E   assert 0 == 1
E    +  where 0 = len([])

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Copy link
Member

@szokeasaurusrex szokeasaurusrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am a bit confused by this PR; I am unsure what its purpose is supposed to be.

How does it relate to #4222? Did you mean to have it based on potel-base or master?

@antonpirker antonpirker marked this pull request as draft April 1, 2025 13:29
@@ -310,7 +336,10 @@ def test_records_lost_event_only_if_traces_sampler_enabled(
sampled_output,
expected_record_lost_event_calls,
):
sentry_init(traces_sampler=traces_sampler)
sentry_init(
traces_sample_rate=None,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test passes only if traces_sample_rate=None and it fails when it is 0 or 1.0. I am not sure if this is the excepted behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants