-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tracing without performance out of the box and deprecated Span.set_data()
#4223
base: potel-base
Are you sure you want to change the base?
Tracing without performance out of the box and deprecated Span.set_data()
#4223
Conversation
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am a bit confused by this PR; I am unsure what its purpose is supposed to be.
How does it relate to #4222? Did you mean to have it based on potel-base
or master
?
@@ -310,7 +336,10 @@ def test_records_lost_event_only_if_traces_sampler_enabled( | |||
sampled_output, | |||
expected_record_lost_event_calls, | |||
): | |||
sentry_init(traces_sampler=traces_sampler) | |||
sentry_init( | |||
traces_sample_rate=None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test passes only if traces_sample_rate=None
and it fails when it is 0
or 1.0
. I am not sure if this is the excepted behavior.
Second part of #4102