replace add data with add series

getsentry · Nov 14, 2024 · 7798b65 · 7798b65
1 parent 00ea404
commit 7798b65
Show file tree

Hide file tree

Showing 6 changed files with 12 additions and 12 deletions.
diff --git a/static/app/views/dashboards/widgetBuilder/buildSteps/yAxisStep/yAxisSelector/index.tsx b/static/app/views/dashboards/widgetBuilder/buildSteps/yAxisStep/yAxisSelector/index.tsx
@@ -169,7 +169,7 @@ export function YAxisSelector({
         <Actions gap={1}>
           <AddButton
             title={
-              displayType === DisplayType.BIG_NUMBER ? t('Add Field') : t('Add Data')
+              displayType === DisplayType.BIG_NUMBER ? t('Add Field') : t('Add Series')
             }
             onAdd={handleAddFields}
           />

diff --git a/static/app/views/dashboards/widgetBuilder/widgetBuilder.spec.tsx b/static/app/views/dashboards/widgetBuilder/widgetBuilder.spec.tsx
@@ -581,8 +581,8 @@ describe('WidgetBuilder', function () {
     // Select line chart display
     await userEvent.click(screen.getByText('Line Chart'));
 
-    // Click the Add Data button
-    await userEvent.click(screen.getByLabelText('Add Data'));
+    // Click the Add Series button
+    await userEvent.click(screen.getByLabelText('Add Series'));
     await selectEvent.select(screen.getByText('(Required)'), ['count_unique(…)']);
 
     await userEvent.click(screen.getByLabelText('Add Widget'));
@@ -1259,7 +1259,7 @@ describe('WidgetBuilder', function () {
     expect(await screen.findByText('Area Chart')).toBeInTheDocument();
 
     // Add a group by
-    await userEvent.click(screen.getByText('Add Data'));
+    await userEvent.click(screen.getByText('Add Series'));
     await selectEvent.select(screen.getByText('Select group'), /project/);
 
     // Change the y-axis
@@ -1308,7 +1308,7 @@ describe('WidgetBuilder', function () {
 
     await selectEvent.select(await screen.findByText('Select group'), 'project');
 
-    await userEvent.click(screen.getByText('Add Data'));
+    await userEvent.click(screen.getByText('Add Series'));
     await selectEvent.select(screen.getByText('(Required)'), /count_unique/);
 
     await waitFor(() => {
@@ -1375,7 +1375,7 @@ describe('WidgetBuilder', function () {
     screen.getByText('Limit to 5 results');
 
     await userEvent.click(screen.getByText('Add Query'));
-    await userEvent.click(screen.getByText('Add Data'));
+    await userEvent.click(screen.getByText('Add Series'));
 
     expect(screen.getByText('Limit to 2 results')).toBeInTheDocument();
   });

diff --git a/static/app/views/dashboards/widgetBuilder/widgetBuilderSortBy.spec.tsx b/static/app/views/dashboards/widgetBuilder/widgetBuilderSortBy.spec.tsx
@@ -524,7 +524,7 @@ describe('WidgetBuilder', function () {
       await userEvent.keyboard('{Enter}');
 
       // Add a y-axis
-      await userEvent.click(screen.getByText('Add Data'));
+      await userEvent.click(screen.getByText('Add Series'));
 
       // The equation should still be visible
       expect(screen.getByPlaceholderText('Enter Equation')).toHaveValue(
@@ -662,7 +662,7 @@ describe('WidgetBuilder', function () {
         },
       });
 
-      await userEvent.click(await screen.findByText('Add Data'));
+      await userEvent.click(await screen.findByText('Add Series'));
       await selectEvent.select(screen.getByText('Select group'), 'project');
 
       // Change the sort by to count_unique

diff --git a/static/app/views/dashboards/widgetCard/releaseWidgetQueries.tsx b/static/app/views/dashboards/widgetCard/releaseWidgetQueries.tsx
@@ -256,7 +256,7 @@ class ReleaseWidgetQueries extends Component<Props, State> {
         widget.queries.map(q => omit(q, ignoredQueryProps)),
         prevProps.widget.queries.map(q => omit(q, ignoredQueryProps))
       ) ||
-      // If the fields changed (ignore falsy/empty fields -> they can happen after clicking on Add Data)
+      // If the fields changed (ignore falsy/empty fields -> they can happen after clicking on Add Series)
       !isEqual(
         widget.queries.flatMap(q => q.fields?.filter(field => !!field)),
         prevProps.widget.queries.flatMap(q => q.fields?.filter(field => !!field))

diff --git a/static/app/views/explore/toolbar/index.spec.tsx b/static/app/views/explore/toolbar/index.spec.tsx
@@ -138,7 +138,7 @@ describe('ExploreToolbar', function () {
     ]);
 
     // try adding an overlay
-    await userEvent.click(within(section).getByRole('button', {name: 'Add Data'}));
+    await userEvent.click(within(section).getByRole('button', {name: 'Add Series'}));
     await userEvent.click(within(section).getByRole('button', {name: 'span.duration'}));
     await userEvent.click(within(section).getByRole('option', {name: 'span.self_time'}));
     expect(visualizes).toEqual([

diff --git a/static/app/views/explore/toolbar/toolbarVisualize.tsx b/static/app/views/explore/toolbar/toolbarVisualize.tsx
@@ -205,9 +205,9 @@ export function ToolbarVisualize({}: ToolbarVisualizeProps) {
                   icon={<IconAdd />}
                   onClick={() => addOverlay(group)}
                   priority="link"
-                  aria-label={t('Add Data')}
+                  aria-label={t('Add Series')}
                 >
-                  {t('Add Data')}
+                  {t('Add Series')}
                 </ToolbarFooterButton>
               </ToolbarFooter>
             </Fragment>