feat(crons): Begin reporting volume_anomaly_result
#79729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #79729 +/- ##
==========================================
- Coverage 78.41% 78.41% -0.01%
==========================================
Files 7147 7147
Lines 315845 315825 -20
Branches 43498 43498
==========================================
- Hits 247685 247654 -31
- Misses 61825 61833 +8
- Partials 6335 6338 +3 |
evanpurkhiser
changed the title
volume_anomaly_result
evanpurkhiser
changed the title
volume_anomaly_result volume_anomaly_result
evanpurkhiser
force-pushed
the
evanpurkhiser/feat-crons-begin-reporting-tick-volume-anomaly-detection
branch
from
a0a723b
to
89d8cd5
Compare
evanpurkhiser
force-pushed
the
evanpurkhiser/feat-crons-begin-reporting-tick-volume-anomaly-detection
branch
from
89d8cd5
to
c3f6536
Compare
evanpurkhiser
force-pushed
the
evanpurkhiser/feat-crons-begin-reporting-tick-volume-anomaly-detection
branch
from
c3f6536
to
c7e8a7f
Compare
This will start with always reporting ticks as having a "normal" volume. Later we will use the volume anomaly detection to inform this value.
evanpurkhiser
force-pushed
the
evanpurkhiser/feat-crons-begin-reporting-tick-volume-anomaly-detection
branch
from
c7e8a7f
to
ec0060f
Compare
evanpurkhiser
commented
Oct 25, 2024
| @@ -85,7 +86,12 @@ def _dispatch_tick(ts: datetime): | |||
| # XXX(epurkhiser): Unclear what we want to do if we're not using kafka | |||
| return | |||
|
|
|||
| message: ClockTick = {"ts": ts.timestamp()} | |||
| volume_anomaly_result = _safe_evaluate_tick_decision(ts) | |||
There was a problem hiding this comment.
Moved tick evaluation into the _dispatch_tick, which probably makes more sense to be the thing to call it
JoshFerge
approved these changes
Nov 6, 2024
evanpurkhiser
deleted the
evanpurkhiser/feat-crons-begin-reporting-tick-volume-anomaly-detection
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will start with always reporting ticks as having a "normal" volume.
Later we will use the volume anomaly detection to inform this value.
Part of GH-79328.
Do not merge this until the previous changes have already rolled out.