-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(flags): Add /secrets resource #80641
base: master
Are you sure you want to change the base?
Conversation
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
This PR has a migration; here is the generated SQL for --
-- Create model FlagWebHookSigningSecretModel
--
CREATE TABLE "flags_webhooksigningsecret" ("id" bigint NOT NULL PRIMARY KEY GENERATED BY DEFAULT AS IDENTITY, "created_by" bigint NULL, "date_added" timestamp with time zone NOT NULL, "provider" varchar NOT NULL, "secret" varchar NOT NULL, "organization_id" bigint NOT NULL);
CREATE UNIQUE INDEX CONCURRENTLY "flags_webhooksigningsecr_organization_id_provider_b6580678_uniq" ON "flags_webhooksigningsecret" ("organization_id", "provider", "secret");
ALTER TABLE "flags_webhooksigningsecret" ADD CONSTRAINT "flags_webhooksigningsecr_organization_id_provider_b6580678_uniq" UNIQUE USING INDEX "flags_webhooksigningsecr_organization_id_provider_b6580678_uniq";
ALTER TABLE "flags_webhooksigningsecret" ADD CONSTRAINT "flags_webhooksigning_organization_id_93de3118_fk_sentry_or" FOREIGN KEY ("organization_id") REFERENCES "sentry_organization" ("id") DEFERRABLE INITIALLY DEFERRED NOT VALID;
ALTER TABLE "flags_webhooksigningsecret" VALIDATE CONSTRAINT "flags_webhooksigning_organization_id_93de3118_fk_sentry_or";
CREATE INDEX CONCURRENTLY "flags_webhooksigningsecret_created_by_c8d80bf9" ON "flags_webhooksigningsecret" ("created_by");
CREATE INDEX CONCURRENTLY "flags_webhooksigningsecret_provider_bc27ff81" ON "flags_webhooksigningsecret" ("provider");
CREATE INDEX CONCURRENTLY "flags_webhooksigningsecret_provider_bc27ff81_like" ON "flags_webhooksigningsecret" ("provider" varchar_pattern_ops);
CREATE INDEX CONCURRENTLY "flags_webhooksigningsecret_organization_id_93de3118" ON "flags_webhooksigningsecret" ("organization_id"); |
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
…cret per provider in the resource
Adds
/secrets
resource which accepts signing-secrets from webhook providers. Updates the hooks endpoint to verify the signature of a provider payload.