Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref: upgrade to python 3.13.0 #80661

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

ref: upgrade to python 3.13.0 #80661

wants to merge 3 commits into from
+38 −38

Conversation

asottile-sentry
Copy link
Member

No description provided.

@github-actions github-actions bot added Scope: Frontend Automatically applied to PRs that change frontend components Scope: Backend Automatically applied to PRs that change backend components labels Nov 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

@codecov Codecov
Copy link

codecov bot commented Nov 13, 2024 •
edited
Loading

❌ 4 Tests Failed:

Tests completed Failed Passed Skipped
23132 4 23128 215
View the top 3 failed tests by shortest run time 
tests.sentry.test_dependencies::test_pydantic_1x_compiled
Stack Traces | 0.036s run time 
#x1B[1m#x1B[31mtests/sentry/test_dependencies.py#x1B[0m:8: in test_pydantic_1x_compiled
    assert pydantic.__file__.endswith(".so")
#x1B[1m#x1B[31mE   AssertionError: assert False#x1B[0m
#x1B[1m#x1B[31mE    +  where False = <built-in method endswith of str object at 0x7f26f5ff28b0>('.so')#x1B[0m
#x1B[1m#x1B[31mE    +    where <built-in method endswith of str object at 0x7f26f5ff28b0> = '.../sentry/sentry/.venv/lib/python3.13....../site-packages/pydantic/__init__.py'.endswith#x1B[0m
#x1B[1m#x1B[31mE    +      where '.../sentry/sentry/.venv/lib/python3.13....../site-packages/pydantic/__init__.py' = pydantic.__file__#x1B[0m
tests.sentry.web.frontend.test_mailgun_inbound_webhook.TestMailgunInboundWebhookView::test_success_no_duplicates
Stack Traces | 4.37s run time 
#x1B[1m#x1B[.../web/frontend/test_mailgun_inbound_webhook.py#x1B[0m:110: in test_success_no_duplicates
    resp = self.client.post(
#x1B[1m#x1B[31m.venv/lib/python3.13.../django/test/client.py#x1B[0m:1158: in post
    response = super().post(
#x1B[1m#x1B[31m.venv/lib/python3.13.../django/test/client.py#x1B[0m:503: in post
    return self.generic(
#x1B[1m#x1B[31m.venv/lib/python3.13.../django/test/client.py#x1B[0m:676: in generic
    return self.request(**r)
#x1B[1m#x1B[31m.venv/lib/python3.13.../django/test/client.py#x1B[0m:1092: in request
    self.check_exception(response)
#x1B[1m#x1B[31m.venv/lib/python3.13.../django/test/client.py#x1B[0m:805: in check_exception
    raise exc_value
#x1B[1m#x1B[31m.venv/lib/python3.13.../core/handlers/exception.py#x1B[0m:55: in inner
    response = get_response(request)
#x1B[1m#x1B[31m.venv/lib/python3.13.../core/handlers/base.py#x1B[0m:197: in _get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
#x1B[1m#x1B[31m.venv/lib/python3.13.../views/generic/base.py#x1B[0m:104: in view
    return self.dispatch(request, *args, **kwargs)
#x1B[1m#x1B[.../sentry/silo/base.py#x1B[0m:158: in override
    return original_method(*args, **kwargs)
#x1B[1m#x1B[31m.venv/lib/python3.13.../django/utils/decorators.py#x1B[0m:48: in _wrapper
    return bound_method(*args, **kwargs)
#x1B[1m#x1B[31m.venv/lib/python3.13.../views/decorators/csrf.py#x1B[0m:65: in _view_wrapper
    return view_func(request, *args, **kwargs)
#x1B[1m#x1B[.../web/frontend/mailgun_inbound_webhook.py#x1B[0m:38: in dispatch
    return super().dispatch(*args, **kwargs)
#x1B[1m#x1B[31m.venv/lib/python3.13.../views/generic/base.py#x1B[0m:143: in dispatch
    return handler(request, *args, **kwargs)
#x1B[1m#x1B[.../web/frontend/mailgun_inbound_webhook.py#x1B[0m:67: in post
    payload = EmailReplyParser.parse_reply(request.POST.get("body-plain", "").strip())
#x1B[1m#x1B[31m.venv/lib/python3.13........./site-packages/email_reply_parser/__init__.py#x1B[0m:32: in parse_reply
    return EmailReplyParser.read(text).reply
#x1B[1m#x1B[31m.venv/lib/python3.13........./site-packages/email_reply_parser/__init__.py#x1B[0m:22: in read
    return EmailMessage(text).read()
#x1B[1m#x1B[31m.venv/lib/python3.13........./site-packages/email_reply_parser/__init__.py#x1B[0m:68: in read
    self.text = re.sub('([^\n])(?=\n ?[_-]{7,})', '\\1\n', self.text, re.MULTILINE)
#x1B[1m#x1B[.../hostedtoolcache/Python/3.13.0.../x64/lib/python3.13/re/__init__.py#x1B[0m:203: in sub
    warnings.warn(
#x1B[1m#x1B[31mE   DeprecationWarning: 'count' is passed as positional argument#x1B[0m
tests.sentry.web.frontend.test_mailgun_inbound_webhook.TestMailgunInboundWebhookView::test_success
Stack Traces | 4.42s run time 
#x1B[1m#x1B[.../web/frontend/test_mailgun_inbound_webhook.py#x1B[0m:82: in test_success
    resp = self.client.post(
#x1B[1m#x1B[31m.venv/lib/python3.13.../django/test/client.py#x1B[0m:1158: in post
    response = super().post(
#x1B[1m#x1B[31m.venv/lib/python3.13.../django/test/client.py#x1B[0m:503: in post
    return self.generic(
#x1B[1m#x1B[31m.venv/lib/python3.13.../django/test/client.py#x1B[0m:676: in generic
    return self.request(**r)
#x1B[1m#x1B[31m.venv/lib/python3.13.../django/test/client.py#x1B[0m:1092: in request
    self.check_exception(response)
#x1B[1m#x1B[31m.venv/lib/python3.13.../django/test/client.py#x1B[0m:805: in check_exception
    raise exc_value
#x1B[1m#x1B[31m.venv/lib/python3.13.../core/handlers/exception.py#x1B[0m:55: in inner
    response = get_response(request)
#x1B[1m#x1B[31m.venv/lib/python3.13.../core/handlers/base.py#x1B[0m:197: in _get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
#x1B[1m#x1B[31m.venv/lib/python3.13.../views/generic/base.py#x1B[0m:104: in view
    return self.dispatch(request, *args, **kwargs)
#x1B[1m#x1B[.../sentry/silo/base.py#x1B[0m:158: in override
    return original_method(*args, **kwargs)
#x1B[1m#x1B[31m.venv/lib/python3.13.../django/utils/decorators.py#x1B[0m:48: in _wrapper
    return bound_method(*args, **kwargs)
#x1B[1m#x1B[31m.venv/lib/python3.13.../views/decorators/csrf.py#x1B[0m:65: in _view_wrapper
    return view_func(request, *args, **kwargs)
#x1B[1m#x1B[.../web/frontend/mailgun_inbound_webhook.py#x1B[0m:38: in dispatch
    return super().dispatch(*args, **kwargs)
#x1B[1m#x1B[31m.venv/lib/python3.13.../views/generic/base.py#x1B[0m:143: in dispatch
    return handler(request, *args, **kwargs)
#x1B[1m#x1B[.../web/frontend/mailgun_inbound_webhook.py#x1B[0m:67: in post
    payload = EmailReplyParser.parse_reply(request.POST.get("body-plain", "").strip())
#x1B[1m#x1B[31m.venv/lib/python3.13........./site-packages/email_reply_parser/__init__.py#x1B[0m:32: in parse_reply
    return EmailReplyParser.read(text).reply
#x1B[1m#x1B[31m.venv/lib/python3.13........./site-packages/email_reply_parser/__init__.py#x1B[0m:22: in read
    return EmailMessage(text).read()
#x1B[1m#x1B[31m.venv/lib/python3.13........./site-packages/email_reply_parser/__init__.py#x1B[0m:68: in read
    self.text = re.sub('([^\n])(?=\n ?[_-]{7,})', '\\1\n', self.text, re.MULTILINE)
#x1B[1m#x1B[.../hostedtoolcache/Python/3.13.0.../x64/lib/python3.13/re/__init__.py#x1B[0m:203: in sub
    warnings.warn(
#x1B[1m#x1B[31mE   DeprecationWarning: 'count' is passed as positional argument#x1B[0m

To view more test analytics, go to the Test Analytics Dashboard
Got feedback? Let us know on Github

@asottile-sentry
ref: upgrade to python 3.13.0
71250e6
@asottile-sentry
ref: upgrade grpcio
5d9999b 
for 3.13
@asottile-sentry
ref: fix monkeypatching of stderr
3b1c428 
something different about python 3.13 causes this to fail on .flush()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@asottile-sentry