feat(alerts): Create eap snuba subscription using rpc timeseries request #80665
+318
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lerts-create-eap-rpc-subscription
github-actions
bot
added
the
Scope: Backend
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #80665 +/- ##
==========================================
+ Coverage 78.35% 78.38% +0.02%
==========================================
Files 7212 7218 +6
Lines 319167 319627 +460
Branches 43946 43999 +53
==========================================
+ Hits 250082 250538 +456
+ Misses 62714 62711 -3
- Partials 6371 6378 +7 |
edwardgou-sentry
force-pushed
the
egou/feat/alerts-create-eap-rpc-subscription
branch
from
2e0d2bb
to
deb0510
Compare
edwardgou-sentry
force-pushed
the
egou/feat/alerts-create-eap-rpc-subscription
branch
from
deb0510
to
b3b7a3f
Compare
| endpoint_name: str, class_version: str, req: SnubaRPCRequest | ||
| endpoint_name: str, | ||
| class_version: str, | ||
| req: SnubaRPCRequest | CreateSubscriptionRequest, |
There was a problem hiding this comment.
Currently, the CreateSubscriptionRequest protobuf doesn't have a meta attribute with a referrer. I've added CreateSubscriptionRequest as a valid type here to handle these scenarios. I'm open to updating the protobuf to include meta instead if we feel that would be better
There was a problem hiding this comment.
I think this is fine for now, I'll clean this up in a future pass 👍
wmak
approved these changes
Nov 14, 2024
| endpoint_name: str, class_version: str, req: SnubaRPCRequest | ||
| endpoint_name: str, | ||
| class_version: str, | ||
| req: SnubaRPCRequest | CreateSubscriptionRequest, |
There was a problem hiding this comment.
I think this is fine for now, I'll clean this up in a future pass 👍
edwardgou-sentry
deleted the
egou/feat/alerts-create-eap-rpc-subscription
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates Alert Rule creation for EAP alerts to use the Create Subscription RPC endpoint in snuba (getsentry/snuba#6499)
Constructs and passes a
TimeSeriesRequestto be used in the subscription creation.