Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(dashboards): Delete is_creator_only_editable col from DashboardPermissions model #80673

Conversation

harshithadurai
Copy link
Member

#80140
Delete is_creator_only_editable col from DashboardPermissions model

@harshithadurai harshithadurai requested review from a team as code owners November 13, 2024 18:42
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Nov 13, 2024
Copy link
Contributor

This PR has a migration; here is the generated SQL for src/sentry/migrations/0789_delete_dashboard_perms_col.py ()

--
-- Custom state/database change combination
--

                    ALTER TABLE "sentry_dashboardpermissions" DROP COLUMN "is_creator_only_editable";

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #80673   +/-   ##
=======================================
  Coverage   78.39%   78.39%           
=======================================
  Files        7207     7207           
  Lines      319387   319387           
  Branches    43986    43986           
=======================================
+ Hits       250391   250392    +1     
+ Misses      62613    62612    -1     
  Partials     6383     6383           

Copy link
Member

@wedamija wedamija left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, although you'll need to add table hints to get the tests to pass

Copy link
Contributor

This PR has a migration; here is the generated SQL for src/sentry/migrations/0790_delete_dashboard_perms_col.py ()

--
-- Custom state/database change combination
--

                    ALTER TABLE "sentry_dashboardpermissions" DROP COLUMN "is_creator_only_editable";

@harshithadurai harshithadurai merged commit c160592 into master Nov 14, 2024
50 checks passed
@harshithadurai harshithadurai deleted the harshi/ref/delete-and-remove-col-from-dashboard-permissions branch November 14, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants