-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref(dashboards): Delete is_creator_only_editable col from DashboardPermissions model #80673
ref(dashboards): Delete is_creator_only_editable col from DashboardPermissions model #80673
Conversation
This PR has a migration; here is the generated SQL for --
-- Custom state/database change combination
--
ALTER TABLE "sentry_dashboardpermissions" DROP COLUMN "is_creator_only_editable"; |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #80673 +/- ##
=======================================
Coverage 78.39% 78.39%
=======================================
Files 7207 7207
Lines 319387 319387
Branches 43986 43986
=======================================
+ Hits 250391 250392 +1
+ Misses 62613 62612 -1
Partials 6383 6383 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, although you'll need to add table hints to get the tests to pass
This PR has a migration; here is the generated SQL for --
-- Custom state/database change combination
--
ALTER TABLE "sentry_dashboardpermissions" DROP COLUMN "is_creator_only_editable"; |
#80140
Delete
is_creator_only_editable
col fromDashboardPermissions
model