Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(explore): change add data to add series #80744

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Conversation

doralchan
Copy link
Contributor

@doralchan doralchan commented Nov 14, 2024

Decided to go with +Add Series instead of +Add Data in query building for clarity
Screenshot 2024-11-14 at 8 26 40 AM
Screenshot 2024-11-14 at 9 07 37 AM

Related to #80615

@doralchan doralchan requested review from a team as code owners November 14, 2024 16:21
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 14, 2024
@doralchan doralchan changed the title feat(explore): replace add data with add series feat(explore): change add data with add series Nov 14, 2024
@doralchan doralchan changed the title feat(explore): change add data with add series feat(explore): change add data to add series Nov 14, 2024
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #80744      +/-   ##
==========================================
- Coverage   78.40%   78.39%   -0.01%     
==========================================
  Files        7209     7209              
  Lines      319379   319379              
  Branches    43984    43984              
==========================================
- Hits       250399   250382      -17     
- Misses      62601    62614      +13     
- Partials     6379     6383       +4     

@doralchan doralchan merged commit ec14f69 into master Nov 14, 2024
50 checks passed
@doralchan doralchan deleted the feat/explore-add-series branch November 14, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants