styles(explore): Only render label for multiple charts #80745
Merged
+6
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there's only 1 chart, there's no need for the extra label as it's not ambiguous.
github-actions
bot
added
the
Scope: Frontend
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #80745 +/- ##
=======================================
Coverage 78.39% 78.39%
=======================================
Files 7209 7207 -2
Lines 319313 319308 -5
Branches 43977 43980 +3
=======================================
- Hits 250315 250313 -2
+ Misses 62621 62615 -6
- Partials 6377 6380 +3 |
Zylphrex
deleted the
txiao/styles/only-render-label-for-multiple-charts
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there's only 1 chart, there's no need for the extra label as it's not ambiguous.