chore(issue-details): Add analytics about sidebar/sections #80766
+29
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
roggenkemper
commented
Nov 14, 2024
|
|
||
| return { | ||
| sidebar_open: localStorage.getItem('issue-details-sidebar-open') === 'true', | ||
| ...sidebarOpenSections, |
There was a problem hiding this comment.
doing it this way because we can't really send an array over and if we sent an individual event for each section open it would be too many events
There was a problem hiding this comment.
doesn't feel like this will be valuable to me since it also depends on if the page even has those sections
scttcper
reviewed
Nov 14, 2024
| @@ -7,7 +7,7 @@ import { | |||
| useReducer, | |||
| } from 'react'; | |||
|
|
|||
| export const enum SectionKey { | |||
|
decided that the existing analytics events should be enough |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr updates the
issue_details.viewedevent with info about if the sidebar was open and what fold sections are open.